feat(profiling): Clean up continuous profiling ui and compat flags (#…

…81260) We can consolidate the continuous-profiling-ui and continuous-profiling-compat flags now as they will be enabled for all orgs.
getsentry · Nov 27, 2024 · 2613081 · 2613081
1 parent 198e038
commit 2613081
Show file tree

Hide file tree

Showing 11 changed files with 41 additions and 701 deletions.
diff --git a/static/app/components/profiling/profileEventsTable.tsx b/static/app/components/profiling/profileEventsTable.tsx
@@ -14,6 +14,7 @@ import {t} from 'sentry/locale';
 import type {Organization} from 'sentry/types/organization';
 import type {Project} from 'sentry/types/project';
 import {defined} from 'sentry/utils';
+import {trackAnalytics} from 'sentry/utils/analytics';
 import {getTimeStampFromTableDateField} from 'sentry/utils/dates';
 import EventView from 'sentry/utils/discover/eventView';
 import {DURATION_UNITS} from 'sentry/utils/discover/fieldRenderers';
@@ -33,8 +34,7 @@ import {
   useDomainViewFilters,
 } from 'sentry/views/insights/pages/useFilters';
 import {getTraceDetailsUrl} from 'sentry/views/performance/traceDetails/utils';
-
-import {ProfilingTransactionHovercard} from './profilingTransactionHovercard';
+import {profilesRouteWithQuery} from 'sentry/views/performance/transactionSummary/transactionProfiles/utils';
 
 interface ProfileEventsTableProps<F extends FieldType> {
   columns: readonly F[];
@@ -236,13 +236,26 @@ function ProfileEventsCell<F extends FieldType>(props: ProfileEventsCellProps<F>
     const project = getProjectForRow(props.baggage, props.dataRow);
 
     if (defined(project)) {
+      const linkToSummary = profilesRouteWithQuery({
+        query: props.baggage.location.query,
+        orgSlug: props.baggage.organization.slug,
+        projectID: project.id,
+        transaction: props.dataRow.transaction,
+      });
+
       return (
         <Container>
-          <ProfilingTransactionHovercard
-            transaction={value}
-            project={project}
-            organization={props.baggage.organization}
-          />
+          <Link
+            to={linkToSummary}
+            onClick={() =>
+              trackAnalytics('profiling_views.go_to_transaction', {
+                organization: props.baggage.organization,
+                source: 'profiling.landing.transaction_table',
+              })
+            }
+          >
+            {props.dataRow.transaction}
+          </Link>
         </Container>
       );
     }

diff --git a/static/app/components/profiling/profilingTransactionHovercard.tsx b/static/app/components/profiling/profilingTransactionHovercard.tsx
diff --git a/static/app/utils/profiling/hooks/useProfileEvents.spec.tsx b/static/app/utils/profiling/hooks/useProfileEvents.spec.tsx
@@ -52,7 +52,7 @@ describe('useProfileEvents', function () {
       match: [
         MockApiClient.matchQuery({
           dataset: 'discover',
-          query: 'has:profile.id (transaction:foo)',
+          query: '(has:profile.id OR (has:profiler.id has:thread.id)) (transaction:foo)',
         }),
       ],
     });

diff --git a/static/app/utils/profiling/hooks/useProfileEvents.tsx b/static/app/utils/profiling/hooks/useProfileEvents.tsx
@@ -14,7 +14,6 @@ export interface UseProfileEventsOptions<F extends string = ProfilingFieldType>
   fields: readonly F[];
   referrer: string;
   sort: Sort<F>;
-  continuousProfilingCompat?: boolean;
   cursor?: string;
   datetime?: PageFilters['datetime'];
   enabled?: boolean;
@@ -30,7 +29,6 @@ export function useProfileEvents<F extends string>({
   referrer,
   query,
   sort,
-  continuousProfilingCompat,
   cursor,
   enabled = true,
   refetchOnMount = true,
@@ -40,11 +38,7 @@ export function useProfileEvents<F extends string>({
   const organization = useOrganization();
   const {selection} = usePageFilters();
 
-  if (continuousProfilingCompat) {
-    query = `(has:profile.id OR (has:profiler.id has:thread.id)) ${query ? `(${query})` : ''}`;
-  } else {
-    query = `has:profile.id ${query ? `(${query})` : ''}`;
-  }
+  query = `(has:profile.id OR (has:profiler.id has:thread.id)) ${query ? `(${query})` : ''}`;
 
   const path = `/organizations/${organization.slug}/events/`;
   const endpointOptions = {

diff --git a/static/app/utils/profiling/hooks/useProfileEventsStats.spec.tsx b/static/app/utils/profiling/hooks/useProfileEventsStats.spec.tsx
@@ -74,7 +74,7 @@ describe('useProfileEvents', function () {
       match: [
         MockApiClient.matchQuery({
           dataset: 'discover',
-          query: 'has:profile.id (transaction:foo)',
+          query: '(has:profile.id OR (has:profiler.id has:thread.id)) (transaction:foo)',
         }),
       ],
     });
@@ -135,7 +135,7 @@ describe('useProfileEvents', function () {
       match: [
         MockApiClient.matchQuery({
           dataset: 'discover',
-          query: 'has:profile.id (transaction:foo)',
+          query: '(has:profile.id OR (has:profiler.id has:thread.id)) (transaction:foo)',
         }),
       ],
     });
@@ -197,7 +197,7 @@ describe('useProfileEvents', function () {
       match: [
         MockApiClient.matchQuery({
           dataset: 'discover',
-          query: 'has:profile.id (transaction:foo)',
+          query: '(has:profile.id OR (has:profiler.id has:thread.id)) (transaction:foo)',
         }),
       ],
     });