Skip to content

Commit

Permalink
feat(spans): Add DLQ topic for buffered spans (#68571)
Browse files Browse the repository at this point in the history
Add DLQ to buffered-segments topic
  • Loading branch information
shruthilayaj authored Apr 18, 2024
1 parent ebb2016 commit 27d14db
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/sentry/conf/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -3484,6 +3484,7 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]
"snuba-spans": "default",
"shared-resources-usage": "default",
"buffered-segments": "default",
"buffered-segments-dlq": "default",
}


Expand Down
1 change: 1 addition & 0 deletions src/sentry/conf/types/kafka_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class Topic(Enum):
SHARED_RESOURCES_USAGE = "shared-resources-usage"
SNUBA_SPANS = "snuba-spans"
BUFFERED_SEGMENTS = "buffered-segments"
BUFFERED_SEGMENTS_DLQ = "buffered-segments-dlq"


class ConsumerDefinition(TypedDict, total=False):
Expand Down
1 change: 1 addition & 0 deletions src/sentry/consumers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ def ingest_events_options() -> list[click.Option]:
"topic": Topic.BUFFERED_SEGMENTS,
"strategy_factory": "sentry.spans.consumers.detect_performance_issues.factory.DetectPerformanceIssuesStrategyFactory",
"click_options": multiprocessing_options(default_max_batch_size=100),
"dlq_topic": Topic.BUFFERED_SEGMENTS_DLQ,
},
**settings.SENTRY_KAFKA_CONSUMERS,
}
Expand Down

0 comments on commit 27d14db

Please sign in to comment.