Merge branch 'priscila/feat/add-private-gaming-sdk-access-modal' into priscila/feat/getting-started-docs/add-xbox-doc

Author: priscilawebdev

migrations_lockfile.txt

@@ -27,7 +27,7 @@ preprod: 0012_installablepreprod
 
 replays: 0006_add_bulk_delete_job
 
-sentry: 0956_add_group_by_to_snuba_query
+sentry: 0957_projecttemplateoption_json
 
 social_auth: 0003_social_auth_json_field
 

src/sentry/migrations/0957_projecttemplateoption_json.py

@@ -0,0 +1,40 @@
+# Generated by Django 5.2.1 on 2025-07-25 08:13
+
+from django.db import migrations, models
+
+from sentry.new_migrations.migrations import CheckedMigration
+
+mod = __import__("sentry.migrations.0929_no_pickle_authenticator", fromlist=["_trash"])
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("sentry", "0956_add_group_by_to_snuba_query"),
+    ]
+
+    operations = [
+        migrations.SeparateDatabaseAndState(
+            database_operations=[mod.to_jsonb("sentry_projecttemplateoption", "value")],
+            state_operations=[
+                migrations.AlterField(
+                    model_name="projecttemplateoption",
+                    name="value",
+                    field=models.JSONField(null=True),
+                ),
+            ],
+        )
+    ]

src/sentry/models/options/project_template_option.py

@@ -7,7 +7,6 @@
 
 from sentry.backup.scopes import RelocationScope
 from sentry.db.models import FlexibleForeignKey, Model, region_silo_model, sane_repr
-from sentry.db.models.fields import PickledObjectField
 from sentry.db.models.manager.option import OptionManager
 from sentry.utils.cache import cache
 
@@ -105,7 +104,7 @@ class ProjectTemplateOption(Model):
 
     project_template = FlexibleForeignKey("sentry.ProjectTemplate", related_name="options")
     key = models.CharField(max_length=64)
-    value = PickledObjectField(null=True)
+    value = models.JSONField(null=True)
 
     objects: ClassVar[ProjectTemplateOptionManager] = ProjectTemplateOptionManager()
 

src/sentry/tempest/tasks.py

@@ -65,11 +65,21 @@ def fetch_latest_item_id(credentials_id: int, **kwargs) -> None:
         result = response.json()
 
         if "latest_id" in result:
-            credentials.latest_fetched_item_id = result["latest_id"]
-            credentials.message = ""
-            credentials.message_type = MessageType.SUCCESS
-            credentials.save(update_fields=["message", "latest_fetched_item_id", "message_type"])
-            return
+            if result["latest_id"] is None:
+                # If there are no crashes in the CRS we want to communicate that back to the
+                # customer so that they are not surprised about no crashes arriving.
+                credentials.message = "No crashes found"
+                credentials.message_type = MessageType.ERROR
+                credentials.save(update_fields=["message", "message_type"])
+                return
+            else:
+                credentials.latest_fetched_item_id = result["latest_id"]
+                credentials.message = ""
+                credentials.message_type = MessageType.SUCCESS
+                credentials.save(
+                    update_fields=["message", "latest_fetched_item_id", "message_type"]
+                )
+                return
         elif "error" in result:
             if result["error"]["type"] == "invalid_credentials":
                 credentials.message = "Seems like the provided credentials are invalid"

src/sentry/utils/sdk_crashes/sdk_crash_detection_config.py

@@ -393,7 +393,7 @@ def build_sdk_crash_detection_configs() -> Sequence[SDKCrashDetectionConfig]:
                     r"package:sentry_link/**",
                     r"package:sentry_firebase_remote_config/**",
                     # obfuscated builds
-                    r"package:/**/.pub-cache/**/sentry**",
+                    r"/**/.pub-cache/**/sentry**",
                 },
                 path_replacer=KeepFieldPathReplacer(fields={"package", "filename", "abs_path"}),
             ),

static/app/components/events/featureFlags/onboarding/featureFlagOnboardingLayout.tsx

@@ -48,6 +48,7 @@ export function FeatureFlagOnboardingLayout({
       platformKey,
       projectId,
       projectSlug,
+      isLogsSelected: false,
       isFeedbackSelected: false,
       isPerformanceSelected: false,
       isProfilingSelected: false,

static/app/components/feedback/feedbackOnboarding/feedbackOnboardingLayout.tsx

@@ -47,6 +47,7 @@ export function FeedbackOnboardingLayout({
       platformKey,
       projectId,
       projectSlug,
+      isLogsSelected: false,
       isFeedbackSelected: true,
       isPerformanceSelected: false,
       isProfilingSelected: false,

static/app/components/onboarding/gettingStartedDoc/onboardingLayout.tsx

@@ -85,6 +85,7 @@ export function OnboardingLayout({
       platformKey,
       projectId,
       projectSlug,
+      isLogsSelected: false,
       isFeedbackSelected: false,
       isPerformanceSelected: activeProductSelection.includes(
         ProductSolution.PERFORMANCE_MONITORING

static/app/components/onboarding/gettingStartedDoc/types.ts

@@ -152,6 +152,7 @@ export interface DocsParams<
   api: Client;
   dsn: ProjectKey['dsn'];
   isFeedbackSelected: boolean;
+  isLogsSelected: boolean;
   isPerformanceSelected: boolean;
   isProfilingSelected: boolean;
   isReplaySelected: boolean;

static/app/components/performanceOnboarding/sidebar.tsx

@@ -335,6 +335,7 @@ function OnboardingContent({currentProject}: {currentProject: Project}) {
     projectId: currentProject.id,
     projectSlug: currentProject.slug,
     isFeedbackSelected: false,
+    isLogsSelected: false,
     isPerformanceSelected: true,
     isProfilingSelected: false,
     isReplaySelected: false,