Skip to content

Commit afdde54

Browse files
JonasBaandrewshie-sentry
authored andcommitted
insights: fix bar height (#91895)
Fixes DE-66
1 parent 81ddfb0 commit afdde54

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

static/app/views/insights/common/components/modulePageFilterBar.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,15 @@ export function ModulePageFilterBar({
106106
otherwise two clicks are required because of some rerendering/event propogation issues into the children */}
107107
<div style={{width: '100px', position: 'absolute', height: '100%'}} />
108108
</Tooltip>
109-
<PageFilterBar condensed>
110-
{!disableProjectFilter && <ProjectPageFilter onChange={onProjectChange} />}
111-
<EnvironmentPageFilter />
112-
<DatePageFilter {...dateFilterProps} />
113-
</PageFilterBar>
109+
{/* Requires an extra div, else the pagefilterbar will grow to fill the height
110+
of the readout ribbon which results in buttons being very large. */}
111+
<div>
112+
<PageFilterBar condensed>
113+
{!disableProjectFilter && <ProjectPageFilter onChange={onProjectChange} />}
114+
<EnvironmentPageFilter />
115+
<DatePageFilter {...dateFilterProps} />
116+
</PageFilterBar>
117+
</div>
114118
{hasDataWithSelectedProjects && extraFilters}
115119
</Fragment>
116120
);

static/app/views/issueDetails/streamline/header/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ const WorkflowActions = styled('div')`
333333

334334
const Workflow = styled('div')`
335335
display: flex;
336+
align-items: center;
336337
gap: ${space(0.5)};
337338
color: ${p => p.theme.subText};
338-
align-items: center;
339339
`;

0 commit comments

Comments
 (0)