Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry cleanup --silent --loglevel ERROR is not silent #13968

Closed
1 of 3 tasks
ganzevoort opened this issue Jul 11, 2019 · 0 comments · Fixed by #13969
Closed
1 of 3 tasks

Sentry cleanup --silent --loglevel ERROR is not silent #13968

ganzevoort opened this issue Jul 11, 2019 · 0 comments · Fixed by #13969

Comments

@ganzevoort
Copy link
Contributor

Important Details

How are you running Sentry?

  • On-Premise docker [Version 9.1.1]
  • Saas (sentry.io)
  • Other [briefly describe your environment]

Description

Cron output is not empty, mails me:

Removing expired values for OrganizationMember

Steps to Reproduce

$ sentry cleanup --days=30 --silent --loglevel ERROR

What you expected to happen

No output.

Possible Solution

There's a fix in #13406
I believe the code there isn't correct. If both is_filtered(models.OrganisationMember) and silent are True, the code will delete expired objects, which I think is incorrect.
@ganzevoort ganzevoort mentioned this issue Jul 11, 2019
Merged
markstory pushed a commit that referenced this issue Jul 11, 2019
@ganzevoort @markstory
fix issue 13968: silent cleanup honors is_filtered (#13969)
d41dbdf 
Expired organisation members would be deleted during silent cleanup
even when filtered (not specified on the command line).

Fixes GH-13968
BYK pushed a commit that referenced this issue Jul 11, 2019
@ganzevoort @BYK
fix issue 13968: silent cleanup honors is_filtered (#13969)
ba0d389 
Expired organisation members would be deleted during silent cleanup
even when filtered (not specified on the command line).

Fixes GH-13968
BYK pushed a commit that referenced this issue Jul 22, 2019
@ganzevoort @BYK
fix issue 13968: silent cleanup honors is_filtered (#13969)
db6e4ee 
Expired organisation members would be deleted during silent cleanup
even when filtered (not specified on the command line).

Fixes GH-13968
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix (cleanup): silent cleanup honors is_filtered ganzevoort/sentry
1 participant
@ganzevoort