Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL syntax highlighting for Request and Response bodies #50230

Closed
marandaneto opened this issue Jun 2, 2023 · 1 comment · Fixed by #50764
Closed

GraphQL syntax highlighting for Request and Response bodies #50230

marandaneto opened this issue Jun 2, 2023 · 1 comment · Fixed by #50764
Assignees
@malwilley

Comments

@marandaneto
Copy link
Contributor

Problem Statement

Request and response bodies are plain text, it's hard to read and find out what's wrong.

Solution Brainstorm

Implement syntax highlighting for request and response when the request is of the type graphql.
If the response has errors, the request body should be highlighted in the faulty line (similar to the source code context).

RFC https://github.com/getsentry/rfcs/blob/main/text/0087-graphql-errors.md
Relay changes getsentry/relay#2141
Notion page https://www.notion.so/sentry/GraphQL-proposal-d6e5846f30434770903cf3af20bc2568

Product Area

Issues
@marandaneto
Copy link
Contributor Author

@scefali @malwilley can you add the right labels and projects? thanks.

@marandaneto marandaneto mentioned this issue Jun 2, 2023
Closed
@malwilley malwilley mentioned this issue Jun 12, 2023
Merged
malwilley added a commit that referenced this issue Jun 13, 2023
@malwilley
feat(graphql): Add special rendering logic for graphql requests (#50764)
0b85048 
Closes #50230

The goal of this PR is to add:
1. Syntax highlighting for the graphql query
2. Add a line highlight when there is a graphql error that points to the
query
This was referenced Jun 19, 2023
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@malwilley malwilley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(graphql): Add special rendering logic for graphql requests getsentry/sentry
3 participants
@marandaneto @scefali @malwilley