Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer transactions get dropped since upgrading to Business 1 week ago #68331

Closed
danielwillemsen opened this issue Apr 5, 2024 · 9 comments
Closed

Comments

@danielwillemsen
Copy link

danielwillemsen commented Apr 5, 2024

Environment

SaaS (https://sentry.io/)

What are you trying to accomplish?

We're using sentry for performance monitoring of some python jobs. Some of them can be pretty long, and thus a single transaction can be long as well. We'd like to receive these transactions in sentry.

How are you getting stuck?

Previously (before March 25th, which is when we upgraded from the team to business plan), any transactions that contained too many spans would be cut short and upon inspecting the event details we'd see the message: "The next spans are unavailable. You may have exceeded the span limit or need to address missing instrumentation" This was acceptable.

After March 25th, these long transactions no longer show up alltogether. Instead, it looks like they are getting dropped upon ingestion. (See attached image from the "stats" window).

Before March 25th, nothing got dropped. Now some transactions do get dropped.

image

I have already turned off all retention policy toggles in the "performance" tab of the project settings, but this didn't affect it.

When running the python task locally & sending the transaction to another (non-prod) environment, the transaction was not filtered out.

What could cause the filtering in this case?

Where in the product are you?

Performance

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Apr 5, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Apr 5, 2024

Routing to @getsentry/product-owners-performance for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 2 Apr 5, 2024
@getsantry getsantry bot moved this from Waiting for: Product Owner to Waiting for: Support in GitHub Issues with 👀 2 Apr 9, 2024
@leeandher
Copy link
Member

Routing back to support with a request from Revenue team to look into the specifics for this customer and determine why the events are being dropped. Once that root cause is identified and determined to be unexpected behavior; then an engineering team can take a look from there.

@dalnoki
Copy link
Contributor

dalnoki commented Apr 10, 2024

Hi @danielwillemsen thanks for your patience here! To make sure that we can take a proper look at this issue, would you mind opening a Support Request here? Could you please share your current SDK package name, version and your Sentry.init()? Thanks a lot in advance!

@getsantry
Copy link
Contributor

getsantry bot commented Apr 18, 2024

Routing to @getsentry/product-owners-ingestion-and-filtering for triage ⏲️

@Dav1dde
Copy link
Member

Dav1dde commented Apr 18, 2024

It is possible that a very large transaction close to the 1mb limit accepted by a Relay goes over the 1mb threshold when Relay enriches/adds information to the transaction, e.g. add tags or metadata.

The forwarded, now bigger than 1mb, transaction will be dropped by the next upstream Relay because it is too big.

The AM2 plan now enabled more performance features which makes Relay add more information pushing the transaction over that 1mb limit.

We'll take a look and plan to trim the transaction so it does stay within the 1mb limit and get back to a similar behaviour you're describing:

Previously[...] any transactions that contained too many spans would be cut short and upon inspecting the event details we'd see the message: "The next spans are unavailable. [...]" This was acceptable.

@danielwillemsen
Copy link
Author

Thanks for the support (through email) and the follow up comments here!

Dav1dde added a commit to getsentry/relay that referenced this issue May 27, 2024
Limits the maximum size of spans to 800kib to stay within the 1mb limit
for transactions.

Due to normalization Relay may add more information to spans which can
push the event over the 1mib limit causing upstream Relays to reject
event, which was initially accepted. Limits the spans to 800kib as a
best effort approach to not go past the limit.

Technically it is still possible to go over the limit, but reducing the
maximum size for spans even further may compromise existing experiences.

Relates to: getsentry/sentry#68331
@jjbayer jjbayer self-assigned this Jun 7, 2024
@jjbayer
Copy link
Member

jjbayer commented Jun 7, 2024

@danielwillemsen we enabled trimming for spans now, did the situation improve for you?

@jjbayer
Copy link
Member

jjbayer commented Jun 14, 2024

@danielwillemsen I'm considering this closed from our side, feel free to reopen if the problem persists.

@jjbayer jjbayer closed this as completed Jun 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

6 participants