-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Notification Settings Input Issues (UI only) #82508
Labels
Comments
Hi, I would like to work on this bug. |
ryan953
pushed a commit
that referenced
this issue
Dec 31, 2024
False as a value in dropdown was causing unexpected behaviour <!-- Describe your PR here. --> Solves this issue : #82508 Changed checks, The setting "Off" was internally represented with the value False, but the front-end logic did not properly handle this case. Earlier : When selected value is Off text field shows "--"   After Change  <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
andrewshie-sentry
pushed a commit
that referenced
this issue
Jan 2, 2025
False as a value in dropdown was causing unexpected behaviour <!-- Describe your PR here. --> Solves this issue : #82508 Changed checks, The setting "Off" was internally represented with the value False, but the front-end logic did not properly handle this case. Earlier : When selected value is Off text field shows "--"   After Change  <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Environment
SaaS (https://sentry.io/)
Steps to Reproduce
From https://sentry.zendesk.com/agent/tickets/141005. Seems to only be related to the UI. Does not affect HTTP requests to backend.
Expected Result
Actual Result
Product Area
Settings
Link
https://sentry.io/settings/account/notifications/
DSN
No response
Version
No response
The text was updated successfully, but these errors were encountered: