Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Notification Settings Input Issues (UI only) #82508

Closed
cobyeastwood183 opened this issue Dec 20, 2024 · 1 comment · Fixed by #82642
Closed

Account Notification Settings Input Issues (UI only) #82508

cobyeastwood183 opened this issue Dec 20, 2024 · 1 comment · Fixed by #82642

Comments

@cobyeastwood183
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to account notification settings
  2. Selecting "Off" on My Own Activity or Resolve and Auto-Assign

From https://sentry.zendesk.com/agent/tickets/141005. Seems to only be related to the UI. Does not affect HTTP requests to backend.

Expected Result

  1. Input is "Off" when Off
  2. Input stays "On" or "Off" after page reload

Actual Result

  1. Input is "--" when Off
  2. Input is "--" and value is "None selected" after page reload

Product Area

Settings

Link

https://sentry.io/settings/account/notifications/

DSN

No response

Version

No response

@nipunh
Copy link
Contributor

nipunh commented Dec 28, 2024

Hi, I would like to work on this bug.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 28, 2024
@ryan953 ryan953 linked a pull request Dec 31, 2024 that will close this issue
ryan953 pushed a commit that referenced this issue Dec 31, 2024
False as a value in dropdown was causing unexpected behaviour

<!-- Describe your PR here. -->
Solves this issue : #82508

Changed checks, The setting "Off" was internally represented with the
value False, but the front-end logic did not properly handle this case.

Earlier : When selected value is Off text field shows "--"
![Screenshot 2024-12-29 at 5 13
46 PM](https://github.com/user-attachments/assets/634e1a55-aa36-4cee-9752-2192a7658440)
![Screenshot 2024-12-29 at 5 13
14 PM](https://github.com/user-attachments/assets/e7bccd89-acb3-4c16-b065-65d444de068d)


After Change
![Screenshot 2024-12-29 at 5 00
43 PM](https://github.com/user-attachments/assets/ecb81db1-d801-4207-aff1-199ee09462fc)

<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
andrewshie-sentry pushed a commit that referenced this issue Jan 2, 2025
False as a value in dropdown was causing unexpected behaviour

<!-- Describe your PR here. -->
Solves this issue : #82508

Changed checks, The setting "Off" was internally represented with the
value False, but the front-end logic did not properly handle this case.

Earlier : When selected value is Off text field shows "--"
![Screenshot 2024-12-29 at 5 13
46 PM](https://github.com/user-attachments/assets/634e1a55-aa36-4cee-9752-2192a7658440)
![Screenshot 2024-12-29 at 5 13
14 PM](https://github.com/user-attachments/assets/e7bccd89-acb3-4c16-b065-65d444de068d)


After Change
![Screenshot 2024-12-29 at 5 00
43 PM](https://github.com/user-attachments/assets/ecb81db1-d801-4207-aff1-199ee09462fc)

<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants