Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade moment-timezone from 0.5.4 #9945

Closed
benvinegar opened this issue Sep 30, 2018 · 0 comments · Fixed by #12966
Closed

Upgrade moment-timezone from 0.5.4 #9945

benvinegar opened this issue Sep 30, 2018 · 0 comments · Fixed by #12966
Assignees
@markstory
Labels
Easy Task

Comments

@benvinegar
Copy link
Contributor

Right now we're using moment-timezone 0.5.4, which uses timezone information from mid-2016. As of time of posting, the timezone information Sentry uses is 2 years out of date.

"How often do timezones change?" – you might be asking yourself. Well, we're off on at least one timezone, Australian Eastern Standard Time (AEST), which is +10 in 0.5.4 but has been updated to the correct +11 in more recent versions.

Refs ISSUE-156
@markstory markstory self-assigned this Oct 1, 2018
markstory added a commit that referenced this issue Apr 26, 2019
@markstory
chore: Bump moment-timezone
24ad03f 
Get the latest in timezone data.

Fixes #9945
@markstory markstory mentioned this issue Apr 26, 2019
Merged
markstory added a commit that referenced this issue Apr 29, 2019
@markstory
chore: Bump moment-timezone (#12966)
c065d95 
Get the latest in timezone data.

Fixes #9945
BYK pushed a commit that referenced this issue Jul 5, 2019
@markstory @BYK
chore: Bump moment-timezone (#12966)
3626966 
Get the latest in timezone data.

Fixes #9945
BYK pushed a commit that referenced this issue Jul 22, 2019
@markstory @BYK
chore: Bump moment-timezone (#12966)
ba25d46 
Get the latest in timezone data.

Fixes #9945
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markstory markstory

Labels
Easy Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bump moment-timezone getsentry/sentry
2 participants
@benvinegar @markstory