chore(dynamic-sampling): quiet redis noise in schedule_invalidate_project_config #101331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vgrozdanic
reviewed
Oct 10, 2025
src/sentry/tasks/relay.py
Outdated
| from sentry.taskworker.namespaces import relay_tasks | ||
| from sentry.utils import metrics | ||
| from sentry.utils.sdk import set_current_event_project | ||
| from sentry.workflow_engine.utils.sentry_level_utils import quiet_redis_noise |
There was a problem hiding this comment.
since this will now be used across sentry, this would be good to move to some shared utils
There was a problem hiding this comment.
@vgrozdanic moved it in this PR - but will be waiting for a review from Kyle to sign off on this, don't want to move this around without communicating it, as it's a quite recent addition
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101331 +/- ##
========================================
Coverage 81.04% 81.04%
========================================
Files 8699 8698 -1
Lines 385838 385831 -7
Branches 24400 24400
========================================
+ Hits 312703 312707 +4
+ Misses 72784 72773 -11
Partials 351 351 |
jjbayer
approved these changes
Oct 13, 2025
shellmayr
force-pushed
the
shellmayr/chore/quiet-redis-noise-dynamic-sampling
branch
from
c594d3b to
9c9f9ed
Compare
shellmayr
deleted the
shellmayr/chore/quiet-redis-noise-dynamic-sampling
branch
|
PR reverted: 9105dc9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TET-1227