Skip to content

feat(billing): add ondemand items to cart and receipt #101376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(billing): add ondemand items to cart and receipt #101376

wants to merge 1 commit into from
+161 −0

Conversation

brendanhsentry
Copy link
Member

@brendanhsentry brendanhsentry commented Oct 10, 2025 •
edited
Loading

Screenshot 2025-10-10 at 1 43 32 PM Screenshot 2025-10-10 at 11 27 32 AM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 10, 2025
@brendanhsentry brendanhsentry marked this pull request as ready for review October 10, 2025 20:53
@brendanhsentry brendanhsentry requested a review from a team as a code owner October 10, 2025 20:53
vbro
vbro approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@vbro vbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit: can the amount be shortened, e.g. 4.9M errors, 187 GB attachments? The exact amount is always available in the PDF receipt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashed dashed dashed approved these changes

@vbro vbro vbro approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brendanhsentry @dashed @vbro