feat(eap): Sets up double deletion of occurrences with EAP #101385
Conversation
github-actions
bot
added
the
Scope: Backend
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def delete_groups_from_eap_rpc( |
There was a problem hiding this comment.
Would like opinions on how to organize this code, e.g. in a separate file as drafted or alongside the Snuba eventstream impl
There was a problem hiding this comment.
I think having a general eventstream/eap.py file to complement the existing eventstream/snuba.py file would fit the existing structure best.
There was a problem hiding this comment.
More general question: do we want to keep the base EventStream interface for the EAP implementation? Maybe a good discussion topic for our sync tomorrow.
| from sentry.testutils.cases import TestCase | ||
|
|
||
|
|
||
| class TestEAPDeletion(TestCase): |
There was a problem hiding this comment.
Basic tests for now, to be improved later
shashjar
changed the title
| filter=combined_filter, | ||
| ) | ||
|
|
||
| request = DeleteTraceItemsRequest( |
There was a problem hiding this comment.
Do the relevant traces have associated sentry.group_ids? I had thought we would need to explicitly pull the trace IDs from the group and delete that way, but would be happy to hear that it does work this way.
There was a problem hiding this comment.
Ah, I see — we're filtering to TraceItems, not to traces themselves. (Comment)
Looks good!
There was a problem hiding this comment.
Yeah — I see that delete using filters is not yet supported in the endpoint implementation, but my assumption was that it eventually will be.
@onewland could you confirm?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101385 +/- ##
===========================================
+ Coverage 81.02% 81.05% +0.02%
===========================================
Files 8701 8678 -23
Lines 386084 385268 -816
Branches 24409 24247 -162
===========================================
- Hits 312837 312285 -552
+ Misses 72896 72629 -267
- Partials 351 354 +3 |
2 participants
Sets up double deletion of occurrences with EAP, as described in ID-997.
When deleting events from eventstore, we should also delete from EAP using the in-progress
DeleteTraceItemsendpoint (protobuf definition).