fix(deletions): Drop prev_history from GroupHistory #102473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a GroupHistory record, Django would CASCADE to all records that reference it via `prev_history`, which can create circular dependency loops. We do not use `prev_history` at all, thus, we can remove it. Fixes [SENTRY-3WN8](https://sentry.sentry.io/issues/6619377437/) and [SENTRY-3WKX](https://sentry.sentry.io/issues/6618890707/).
github-actions
bot
added
the
Scope: Backend
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Member
Author
|
Alright it seems I need to follow this process first: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # is a schema change, it's completely safe to run the operation after the code has deployed. | ||
| # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment | ||
|
|
||
| is_post_deployment = False |
Contributor
There was a problem hiding this comment.
Bug: Bug
The migration to remove the prev_history column is marked is_post_deployment = False. This means the column will be dropped during deployment, risking database errors if older application instances try to access the field. This doesn't align with Sentry's safe column deletion process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a GroupHistory record, Django would CASCADE to all records that reference it via
prev_history, which can create circular dependency loops.We do not use
prev_historyat all, thus, we can remove it.Fixes SENTRY-3WN8 and SENTRY-3WKX.