Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sentry/users/api/endpoints/user_details.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ class UserOptionsSerializer(serializers.Serializer[UserOption]):
required=False,
)
prefersIssueDetailsStreamlinedUI = serializers.BooleanField(required=False)
prefersNextjsInsightsOverview = serializers.BooleanField(required=False)
prefersChonkUI = serializers.BooleanField(required=False)


Expand Down Expand Up @@ -237,7 +236,6 @@ def put(self, request: Request, user: User) -> Response:
"defaultIssueEvent": "default_issue_event",
"clock24Hours": "clock_24_hours",
"prefersIssueDetailsStreamlinedUI": "prefers_issue_details_streamlined_ui",
"prefersNextjsInsightsOverview": "prefers_nextjs_insights_overview",
"prefersChonkUI": "prefers_chonk_ui",
}

Expand Down
4 changes: 0 additions & 4 deletions src/sentry/users/api/serializers/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ class _UserOptions(TypedDict):
timezone: str
clock24Hours: bool
prefersIssueDetailsStreamlinedUI: bool | None
prefersNextjsInsightsOverview: bool
prefersChonkUI: bool | None


Expand Down Expand Up @@ -213,9 +212,6 @@ def serialize(
"defaultIssueEvent": options.get("default_issue_event") or "recommended",
"timezone": options.get("timezone") or settings.SENTRY_DEFAULT_TIME_ZONE,
"clock24Hours": options.get("clock_24_hours") or False,
"prefersNextjsInsightsOverview": options.get(
"prefers_nextjs_insights_overview", True
),
"prefersIssueDetailsStreamlinedUI": options.get(
"prefers_issue_details_streamlined_ui"
),
Expand Down
2 changes: 0 additions & 2 deletions src/sentry/users/models/user_option.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ class UserOption(Model):
- unused
- prefers_issue_details_streamlined_ui
- Whether the user prefers the new issue details experience (boolean)
- prefers_nextjs_insights_overview
- Whether the user prefers the new NextJS insights overview experience (boolean)
- prefers_chonk_ui
- Whether the user prefers the new Chonk UI experience (boolean)
- language
Expand Down
27 changes: 0 additions & 27 deletions tests/sentry/users/api/endpoints/test_user_details.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ def test_simple(self) -> None:
"clock24Hours": True,
"extra": True,
"prefersIssueDetailsStreamlinedUI": True,
"prefersNextjsInsightsOverview": True,
"prefersChonkUI": True,
},
)
Expand All @@ -145,7 +144,6 @@ def test_simple(self) -> None:
user=self.user, key="prefers_issue_details_streamlined_ui"
)
assert UserOption.objects.get_value(user=self.user, key="prefers_chonk_ui")
assert UserOption.objects.get_value(user=self.user, key="prefers_nextjs_insights_overview")

assert not UserOption.objects.get_value(user=self.user, key="extra")

Expand Down Expand Up @@ -211,31 +209,6 @@ def test_cannot_change_username_to_non_verified(self) -> None:
assert user.email == "c@example.com"
assert user.username == "c@example.com"

def test_saving_nextjs_insights_overview_option(self) -> None:
self.get_success_response(
"me",
options={"prefersNextjsInsightsOverview": True},
)
assert (
UserOption.objects.get_value(user=self.user, key="prefers_nextjs_insights_overview")
is True
)

self.get_success_response(
"me",
options={"prefersNextjsInsightsOverview": False},
)
assert (
UserOption.objects.get_value(user=self.user, key="prefers_nextjs_insights_overview")
is False
)

def test_default_nextjs_insights_overview_option_is_true(self) -> None:
resp = self.get_success_response(
"me",
)
assert resp.data["options"]["prefersNextjsInsightsOverview"] is True


@control_silo_test
class UserDetailsSuperuserUpdateTest(UserDetailsTest):
Expand Down
Loading