feat(onboarding): Add metrics onboarding for the Python SDK #102641
+741
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 15 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
alexander-alderman-webb
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Undefined valueType triggers unintended filter initialization paths
The condition change from valueType && valueType !== FieldValueType.STRING to fieldDefinition?.valueType !== FieldValueType.STRING causes the code block to execute when fieldDefinition?.valueType is undefined. This previously skipped block now calls getInitialFilterText with undefined parameters, which could lead to unexpected behavior or runtime errors.
static/app/views/dashboards/globalFilter/addFilter.tsx#L130-L131
sentry/static/app/views/dashboards/globalFilter/addFilter.tsx
Lines 130 to 131 in 8787b29
| description={t( | ||
| 'Structured application metrics for debugging and troubleshooting. Automatically gets associated with errors and traces.' | ||
| )} | ||
| docLink="https://docs.sentry.io/product/explore/metrics/" |
There was a problem hiding this comment.
This redirects to span metrics right now. Not sure which page to link, but this should be addressed here or in the docs repo before merging as well.
| <Product | ||
| label={t('Metrics')} | ||
| description={t( | ||
| 'Structured application metrics for debugging and troubleshooting. Automatically gets associated with errors and traces.' |
There was a problem hiding this comment.
Open to suggestions, I didn't change much from the description we have for logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LOGS-458