ref(onboarding): Split gcp functions onboarding docs #102650
Merged
+76
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| textWithMarkupMatcher( | ||
| /const Sentry = require\("@sentry\/google-cloud-serverless"\);/ | ||
| ) | ||
| textWithMarkupMatcher(/import \* as Sentry from "@sentry\/google-cloud-serverless"/) |
Contributor
There was a problem hiding this comment.
Bug: ESM vs CJS Mismatch in SDK Snippet
The test expects an ESM import statement (import * as Sentry from "@sentry/google-cloud-serverless"), but the code generates a CJS require statement (const Sentry = require("@sentry/google-cloud-serverless");). The getSdkInitSnippet(params, 'gpc') call in onboarding.tsx does not pass a defaultMode parameter, so it defaults to CJS format. The test regex should be /const Sentry = require\("@sentry\/google-cloud-serverless"\);/ instead of /import \* as Sentry from "@sentry\/google-cloud-serverless"/.
ArthurKnaus
approved these changes
Nov 6, 2025
priscilawebdev
deleted the
priscila/ref/onboarding/split-gcpfunctions-onboarding-docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://linear.app/getsentry/issue/TET-864/introduce-folders-for-onboarding-platforms