-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(ai-consent): Skip consent screen for issue summary #102687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| areAiFeaturesAllowed && | ||
| !organization.features.includes('gen-ai-consent-flow-removal'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your backend PR returns True for consent when this feature flag is there, so won't these checks automatically pass then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's true, I can remove this
| {(aiConfig.orgNeedsGenAiAcknowledgement || | ||
| (!removeConsentFlow && !aiConfig.hasAutofixQuota)) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is making issue summary available for free something we also want to roll out gradually, or are we only doing a gradual roll out for removing consent?
Because if making it free can be immediate, we could just remove the hasAutofixQuota check, and the orgNeedsGenAiAcknowledgement would still apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather roll them both out with a flag so that we can quickly roll back if something goes wrong. I'll remove the check completely after the rollout
Changes gated with the flag
gen-ai-consent-flow-removalBefore: If org has not given consent, or has not purchased Seer, a placeholder was shown:
After: Issue summary is fetched and displayed for all orgs, regardless of whether or not they have consented or paid for Seer.