Skip to content

Conversation

@jan-auer
Copy link
Member

@jan-auer jan-auer commented Dec 19, 2018

Changes normalization of the Http interface (request):

  • Content type inference still happens, but the body is left as it was ingested.
  • Query strings are now stored as pair lists internally, not as string.

@jan-auer jan-auer self-assigned this Dec 19, 2018
@jan-auer jan-auer changed the title ref(interfaces): Do not re-serialize request bodies ref(interfaces): Update the Http interface (request) Dec 19, 2018
@jan-auer jan-auer requested a review from mitsuhiko December 19, 2018 16:26
@jan-auer
Copy link
Member Author

I still want to change the create_sample_event code for tests so that it doesn't add arbitrary interfaces to the sample JSONs. Just need to verify what implications this might have to the seed functionality in prod.

@jan-auer jan-auer force-pushed the ref/request-interface branch from 5ff19b3 to 0705783 Compare January 4, 2019 09:13
@jan-auer jan-auer force-pushed the ref/request-interface branch from 0705783 to 30b80c4 Compare January 7, 2019 13:46
@jan-auer jan-auer requested a review from untitaker January 7, 2019 13:54
@jan-auer
Copy link
Member Author

jan-auer commented Jan 7, 2019

We will split this up in two PRs to further minimize the impact. Query string changes are good to go, the body parsing change needs one final review.

@untitaker
Copy link
Member

#11414 #11413 supersede this

@untitaker untitaker closed this Jan 8, 2019
@untitaker untitaker deleted the ref/request-interface branch January 8, 2019 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants