feat(releases): Add all/new events components for org releases #11369
Conversation
lynnagara
force-pushed
the
feat/release-events
branch
from
996b093 to
9864ca4
Compare
| <Link | ||
| to={{ | ||
| pathname: `/organizations/${orgId}/issues/`, | ||
| query: {query: 'release:' + this.context.release.version}, |
There was a problem hiding this comment.
Why is version not wrapped in " here? Should you URLencode release.version? It can contain URL unsafe data.
There was a problem hiding this comment.
Using query seems to automatically encode this for us
There was a problem hiding this comment.
I'm not exactly sure what the impact of wrapping in " is in the stream view (afaik both are valid) but since i'm not confident I've gone with the same implementation as the project releases version here https://github.com/getsentry/sentry/blob/master/src/sentry/static/sentry/app/views/releases/detail/project/releaseAllEvents.jsx#L27
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
The two components are pretty similar, they could be the same component with 2 additional props - it's fine as is though.
src/sentry/static/sentry/app/views/releases/detail/organization/releaseAllEvents.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/releases/detail/organization/releaseAllEvents.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/releases/detail/organization/releaseNewEvents.jsx
Outdated
Show resolved
Hide resolved
| query: {query: 'first-release:' + this.context.release.version}, | ||
| }} | ||
| > | ||
| <span className="icon icon-open" /> |
src/sentry/static/sentry/app/views/releases/detail/organization/releaseNewEvents.jsx
Outdated
Show resolved
Hide resolved
No description provided.