Skip to content

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Jan 8, 2019

This was crashing because formatted was an empty string and it was attempting to fetch an annotated message that did not exist. This fixes the message interface and makes sure Annotated does not return undefined.

Also add an error boundary for MetaData so that we can fail gracefully in the future

Fixes JAVASCRIPT-4Z1

This was crashing because `formatted` was an empty string and it was attempting to fetch an annotated `message` that did not exist. This fixes the message interface and makes sure `Annotated` does not return undefined.

Also add an error boundary for MetaData so that we can fail gracefully in the future

Fixes JAVASCRIPT-4Z1
@billyvg billyvg requested a review from a team January 8, 2019 18:59
Copy link
Contributor

@macqueen macqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg billyvg merged commit ee47c73 into master Jan 8, 2019
@billyvg billyvg deleted the fix/ui/fix-messages-interface-metadata branch January 8, 2019 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants