Skip to content

test(percy): Fix assistant flakiness on issue details #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 1 commit into from
Jan 24, 2019
Merged

test(percy): Fix assistant flakiness on issue details #11680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/acceptance/test_issue_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def test_empty_exception(self):
self.browser.get(
u'/{}/{}/issues/{}/'.format(self.org.slug, self.project.slug, event.group.id)
)
self.wait_until_loaded()
self.wait_until_loaded(skip_assistant=True)
self.browser.snapshot('issue details empty exception')

def test_empty_stacktrace(self):
Expand All @@ -149,7 +149,7 @@ def test_empty_stacktrace(self):
self.browser.get(
u'/{}/{}/issues/{}/'.format(self.org.slug, self.project.slug, event.group.id)
)
self.wait_until_loaded()
self.wait_until_loaded(skip_assistant=True)
self.browser.snapshot('issue details empty stacktrace')

def test_invalid_interfaces(self):
Expand All @@ -160,7 +160,7 @@ def test_invalid_interfaces(self):
self.browser.get(
u'/{}/{}/issues/{}/'.format(self.org.slug, self.project.slug, event.group.id)
)
self.wait_until_loaded()
self.wait_until_loaded(skip_assistant=True)
self.browser.click('.errors-toggle')
self.browser.wait_until('.entries > .errors ul')
self.browser.snapshot('issue details invalid interfaces')
Expand All @@ -176,8 +176,10 @@ def test_activity_page(self):
self.browser.wait_until('.activity-item')
self.browser.snapshot('issue activity python')

def wait_until_loaded(self):
def wait_until_loaded(self, skip_assistant=None):
self.browser.wait_until('.entries')
self.browser.wait_until('[data-test-id="linked-issues"]')
self.browser.wait_until('[data-test-id="loaded-device-name"]')
if skip_assistant is None:
self.browser.wait_until('[data-test-id="assistant-cue"]')
self.browser.wait_until_not('.loading-indicator')