Skip to content

fix: Deal with new querystrings in issue details #11713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
untitaker merged 3 commits into from
Jan 28, 2019
Merged

fix: Deal with new querystrings in issue details #11713

untitaker merged 3 commits into from
Jan 28, 2019

Conversation

@untitaker
Copy link
Member

@untitaker untitaker commented Jan 25, 2019 •
edited
Loading

Fix ISSUE-296

@untitaker untitaker requested review from billyvg and jan-auer January 25, 2019 09:20
billyvg
billyvg approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Does this address a sentry issue? A PR description would be nice to have.

src/sentry/static/sentry/app/components/events/interfaces/utils.jsx
result += '"';
return result;
let queryObj = {};
for (let [k, v] of query) {
Copy link
Member

@billyvg billyvg Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we not stringify query directly?

@untitaker
Copy link
Member Author

untitaker commented Jan 25, 2019

Sorry, I forgot to link the JIRA issue. I'll try to make a brief summary here because the JIRA ticket contains too much PII

The gist is that we fixed #11606, but a similar bug happened somewhere else: A querystring like foo=bar&baz=bam would previously be sent as string through the API. We changed this to send a list of lists, but didnt consider testing the UI.

Right now the clickable URL is broken in all events that have a querystring. It serializes out the above querystring as foo,bar,baz,bam, which is nonsense.

@untitaker untitaker merged commit 44797b1 into master Jan 28, 2019
@untitaker untitaker deleted the fix/more-query-string-stuff branch January 28, 2019 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@billyvg billyvg billyvg approved these changes

@jan-auer jan-auer Awaiting requested review from jan-auer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@untitaker @billyvg @jan-auer