Skip to content

ref: Sample to_python calls #12090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 6, 2019
Merged

ref: Sample to_python calls #12090

merged 16 commits into from
Mar 6, 2019

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Feb 15, 2019

#sync-getsentry

@untitaker untitaker force-pushed the ref/sample-to-python branch from e9b80bc to f46f947 Compare February 15, 2019 13:49
@untitaker untitaker requested review from mitsuhiko and jan-auer and removed request for mitsuhiko February 15, 2019 14:06
@untitaker untitaker changed the title ref: Sample to_python calls [wip] ref: Sample to_python calls Mar 4, 2019
@untitaker untitaker requested review from mitsuhiko and jan-auer March 5, 2019 09:38
@untitaker untitaker changed the title [wip] ref: Sample to_python calls ref: Sample to_python calls Mar 5, 2019
Copy link
Contributor

@mitsuhiko mitsuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on a first glace. I think we can merge and try this tomorrow.

@untitaker untitaker merged commit ec269b5 into master Mar 6, 2019
@untitaker untitaker deleted the ref/sample-to-python branch March 6, 2019 09:01
untitaker added a commit that referenced this pull request Mar 6, 2019
untitaker added a commit that referenced this pull request Mar 6, 2019
untitaker added a commit that referenced this pull request Mar 12, 2019
untitaker added a commit that referenced this pull request Mar 18, 2019
* Revert "Revert "ref: Sample to_python calls (#12090)" (#12308)"

This reverts commit d0dd8db.

* ref: Use event-id for sampling

* fix: Also run tests with new path enabled

* fix: Fix wrong setdefault

* fix: Fix UI side to deal with invalid values

* fix: Allow failures in travis

* fix: Revert unnecessary changes

* fix: Safeguard for sample rate
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants