-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref: Sample to_python calls #12090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ref: Sample to_python calls #12090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9b80bc
to
f46f947
Compare
mitsuhiko
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good on a first glace. I think we can merge and try this tomorrow.
untitaker
added a commit
that referenced
this pull request
Mar 6, 2019
untitaker
added a commit
that referenced
this pull request
Mar 12, 2019
untitaker
added a commit
that referenced
this pull request
Mar 18, 2019
* Revert "Revert "ref: Sample to_python calls (#12090)" (#12308)" This reverts commit d0dd8db. * ref: Use event-id for sampling * fix: Also run tests with new path enabled * fix: Fix wrong setdefault * fix: Fix UI side to deal with invalid values * fix: Allow failures in travis * fix: Revert unnecessary changes * fix: Safeguard for sample rate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#sync-getsentry