ref: Measure event size in eventstream #12480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
previously approved these changes
Mar 20, 2019
jan-auer
approved these changes
Mar 20, 2019
|
Also fixing Percy while we're at it. I believe there's a race between the two acceptance test jobs we have (the regular one and the copypasted one for the purpose of rolling this stuff out) |
jan-auer
added a commit
that referenced
this pull request
Mar 21, 2019
* master: (31 commits) fix(shared-issues): Fix shared issues page crashing (#12490) feat(grouping): Ignore unknown functions in native (#12486) feat: use SimpleEventSerializer for grouop event list (#12485) feat: Implement next_event and prev_event for SnubaEvent (#12404) ref: Measure event size in eventstream (#12480) fix: Empty migration to fix south state feat(ui): Upgrade "u2f-api" to 1.0.10 [SEN-209] (#12477) fix(integrations) Make logger name consistent (#12473) Revert "fix(app-platform): Conditionally make requests (#12476)" (#12479) feat(api): Add endpoint to create recent searches (SEN-353) feat(api): Add data model for recent searches, and endpoint to list them (SEN-350, SEN-349) ref(dev): Use webpack proxy in place of devserver.js (#12468) fix(app-platform): Conditionally make requests (#12476) feat(grouping): Add project option to force grouping and persist it (#12432) ref: Don't shadow the real user interface. (#12472) feat(saved-search): Request searches with `use_org_level=1` if flag is active (#12460) ref(debugfile): Add code identifiers (#12448) perf: Avoid uncached feature checks on /store (#12464) feat(app-platform): Add stacktrace-link UI (#12457) ref(api) Optimize organization details to not load data twice (#12431) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event size is already measured in
post_process_group, so it should not be part of the reason #12375 can't be rolled out without post-process-forwarder/workerrelay being immediately backlogged, but I am running out of ideas.I tried benching
Eventcreation locally with both0.0and1.0as sample rates and there's no difference at all.