ref(slack): Implement bot app switch #13184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
force-pushed
the
refslack-implement-bot-app-switch
branch
2 times, most recently
from
bc8cc13 to
ddb26f8
Compare
markstory
reviewed
May 13, 2019
Ourselves, No:This is something we've been discussing with the folks over at Slack. Unfortunately because the workspace tokens and bot tokens are different, we would have to ask all of our users to re-authorize their application. The team over at Slack is working on a solution in the mid-term (I believe) to provide a migration path for workspace token apps back to bot apps. Users (onprem), Yes:We should document this change in the on-premise forum post for the slack integration. /cc @jessla |
wedamija
reviewed
May 14, 2019
| @@ -141,3 +143,109 @@ def test_reassign_user(self): | |||
| self.assert_setup_flow(authorizing_user_id='UXXXXXXX2') | |||
| identity = Identity.objects.get() | |||
| assert identity.external_id == 'UXXXXXXX2' | |||
|
|
|||
|
|
|||
| class SlackIntegrationBotAppTest(IntegrationTestCase): | |||
There was a problem hiding this comment.
This code is almost identical to SlackIntegrationTest, can this be abstracted?
There was a problem hiding this comment.
Yeah I'll pull out a base class
Introduces as SLACK_INTEGRATION_USER_WST setting that can be enabled to use the legacy workspace token apps (which is what sentry.io uses). - When installing the integration we now use scopes depending on if the workspace token app setting is enabled. Otherwise we use bot tokens. NOTE that the WST app scopes have not changed. - When using bot tokens we must store the bot token _and_ user token to handle unfurling. - We can still pre-link the authorizing user, but we have to make a API request first to receive the users ID.
evanpurkhiser
force-pushed
the
refslack-implement-bot-app-switch
branch
from
ddb26f8 to
1e2a63b
Compare
wedamija
approved these changes
May 16, 2019
|
When will this fix make a release? |
Merged
BYK
pushed a commit
that referenced
this pull request
Jul 5, 2019
Introduces as SLACK_INTEGRATION_USER_WST setting that can be enabled to use the legacy workspace token apps (which is what sentry.io uses). - When installing the integration we now use scopes depending on if the workspace token app setting is enabled. Otherwise we use bot tokens. NOTE that the WST app scopes have not changed. - When using bot tokens we must store the bot token _and_ user token to handle unfurling. - We can still pre-link the authorizing user, but we have to make a API request first to receive the users ID.
BYK
pushed a commit
that referenced
this pull request
Jul 22, 2019
Introduces as SLACK_INTEGRATION_USER_WST setting that can be enabled to use the legacy workspace token apps (which is what sentry.io uses). - When installing the integration we now use scopes depending on if the workspace token app setting is enabled. Otherwise we use bot tokens. NOTE that the WST app scopes have not changed. - When using bot tokens we must store the bot token _and_ user token to handle unfurling. - We can still pre-link the authorizing user, but we have to make a API request first to receive the users ID.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces as
SLACK_INTEGRATION_USER_WSTsetting that can be enabled to use the legacy workspace token apps (which is what sentry.io uses).When installing the integration we now use appropriate scopes depending on if the workspace token app setting is enabled. Otherwise we use bot app scopes. NOTE that the WST app scopes have not changed.
When using bot tokens we must store the bot token and user token to handle unfurling, as unfurling cannot be done with just a bot token.
We can still pre-link the authorizing user, but we have to make a API request first to receive the users ID.
/cc @Roach @hwz
Fixes #9004
NOTE TO SELF: Do not merge until sentry.io has the associated WST configuration enabled: https://github.com/getsentry/getsentry/pull/2917