Skip to content

feat(ui): Change <DropdownMenu> to expose open/close actions in render func #13443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019
Merged

feat(ui): Change <DropdownMenu> to expose open/close actions in render func #13443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sentry/static/sentry/app/components/dropdownMenu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,10 @@ class DropdownMenu extends React.Component {
getRootProps: this.getRootProps,
getActorProps: this.getActorProps,
getMenuProps: this.getMenuProps,
actions: {
open: this.handleOpen,
close: this.handleClose,
Copy link
Member

@markstory markstory May 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would you need to control the menu state this way? Just saw your other pull request.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry, forgot to link the two

},
});
}
}
Expand Down