Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sentry10): Remove sentry 9 stream components #13528

Merged
merged 2 commits into from
Jun 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/sentry/static/sentry/app/actionCreators/tags.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import {Client} from 'app/api';
import {t} from 'app/locale';
import TagStore from 'app/stores/tagStore';
import TagActions from 'app/actions/tagActions';
Expand Down Expand Up @@ -61,21 +60,6 @@ function tagFetchSuccess(tags) {
TagActions.loadTagsSuccess(trimmedTags);
}

/**
* Fetch tags for a single project
*/
export function fetchProjectTags(orgId, projectId) {
TagStore.reset();
TagActions.loadTags();
const api = new Client();
const url = `/projects/${orgId}/${projectId}/tags/`;

const promise = api.requestPromise(url);
promise.then(tagFetchSuccess, TagActions.loadTagsError);

return promise;
}

/**
* Fetch tag values for a single project. Used for sentry9 views.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
} from 'app/actionCreators/savedSearches';
import {t} from 'app/locale';
import Button from 'app/components/button';
import CreateSavedSearchButton from 'app/views/stream/createSavedSearchButton';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we even need this organization designation at all for our upper level views since project settings are really the only things that should be project specific now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does seem a lot less meaningful now that everything is organization level. I can drop the organization prefix if we agree that's the naming direction we want to go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should decide + do this in another PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on removing the prefix. It doesn't add anything when we only have organization scoped views.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worthwhile to discuss this + the root views directory in general tomorrow in the TSC?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

import CreateSavedSearchButton from 'app/views/organizationStream/createSavedSearchButton';
import InlineSvg from 'app/components/inlineSvg';
import MemberListStore from 'app/stores/memberListStore';
import SentryTypes from 'app/sentryTypes';
Expand Down
28 changes: 3 additions & 25 deletions src/sentry/static/sentry/app/routes.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -1155,27 +1155,9 @@ function routes() {
</Route>

<Route path=":projectId/" component={errorHandler(ProjectDetails)}>
<IndexRoute
componentPromise={() =>
import(/* webpackChunkName: "Stream" */ './views/stream')
}
component={errorHandler(LazyLoad)}
/>
<Route
path="issues/"
componentPromise={() =>
import(/* webpackChunkName: "Stream" */ './views/stream')
}
component={errorHandler(LazyLoad)}
/>

<Route
path="searches/:searchId/"
componentPromise={() =>
import(/* webpackChunkName: "Stream" */ './views/stream')
}
component={errorHandler(LazyLoad)}
/>
<IndexRedirect to="/organizations/:orgId/issues/" />
<Redirect from="issues/" to="/organizations/:orgId/issues/" />
<Redirect from="searches/:searchId/" to="/organizations/:orgId/issues/" />
<Route
path="dashboard/"
componentPromise={() =>
Expand Down Expand Up @@ -1234,9 +1216,7 @@ function routes() {
component={errorHandler(LazyLoad)}
/>
</Route>

<Redirect from="user-feedback/" to="/organizations/:orgId/user-feedback/" />

<Route path="settings/" component={errorHandler(ProjectSettings)}>
<Redirect from="teams/" to="/settings/:orgId/projects/:projectId/teams/" />
<Redirect from="alerts/" to="/settings/:orgId/projects/:projectId/alerts/" />
Expand Down Expand Up @@ -1344,7 +1324,6 @@ function routes() {
/>
{projectSettingsRoutes}
</Route>

<Redirect from="group/:groupId/" to="issues/:groupId/" />
<Route
path="issues/:groupId/"
Expand Down Expand Up @@ -1372,7 +1351,6 @@ function routes() {
<Route path="similar/" component={errorHandler(ProjectGroupSimilarView)} />
<Route path="merged/" component={errorHandler(ProjectGroupMergedView)} />
</Route>

<Route path="events/:eventId/" component={errorHandler(ProjectEventRedirect)} />
</Route>
</Route>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ class StreamFilters extends React.Component {
};

static defaultProps = {
projectId: null,
sort: '',
query: null,
onSortChange: function() {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,17 @@ import Pagination from 'app/components/pagination';
import ProcessingIssueList from 'app/components/stream/processingIssueList';
import SelectedGroupStore from 'app/stores/selectedGroupStore';
import SentryTypes from 'app/sentryTypes';
import StreamActions from 'app/views/stream/actions';
import StreamFilters from 'app/views/stream/filters';
import StreamGroup from 'app/components/stream/group';
import StreamSidebar from 'app/views/stream/sidebar';
import TagStore from 'app/stores/tagStore';
import parseApiError from 'app/utils/parseApiError';
import parseLinkHeader from 'app/utils/parseLinkHeader';
import utils from 'app/utils';
import withGlobalSelection from 'app/utils/withGlobalSelection';
import withOrganization from 'app/utils/withOrganization';
import withSavedSearches from 'app/utils/withSavedSearches';
import StreamActions from './actions';
import StreamFilters from './filters';
import StreamSidebar from './sidebar';

const MAX_ITEMS = 25;
const DEFAULT_QUERY = 'is:unresolved';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import PropTypes from 'prop-types';
import React from 'react';
import createReactClass from 'create-react-class';
import _ from 'lodash';
import StreamTagFilter from 'app/views/stream/tagFilter';
import LoadingIndicator from 'app/components/loadingIndicator';
import {queryToObj, objToQuery} from 'app/utils/stream';
import {t} from 'app/locale';
import StreamTagFilter from './tagFilter';

const TEXT_FILTER_DEBOUNCE_IN_MS = 300;

Expand Down
57 changes: 0 additions & 57 deletions src/sentry/static/sentry/app/views/stream/index.jsx

This file was deleted.

Loading