Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installWizard): Fix client default values not set #13726

Merged
merged 5 commits into from
Jun 18, 2019
Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Jun 18, 2019

Fixes #12813.

Just checked the payload to the server after the fix, it is now as follows w/ onpremise:

{
    "auth.allow-registration": false,
    "beacon.anonymous": false,
    "mail.from": "root@localhost",
    "mail.password": "lol really",
    "mail.port": 25,
    "mail.use-tls": false,
    "mail.username": "root",
    "system.admin-email": "ben@byk.im",
    "system.url-prefix": "http://localhost:9000"
}

This also indeed fixes the empty DSN issue.

@BYK BYK requested review from dcramer and billyvg June 18, 2019 17:52
Copy link
Member

@dcramer dcramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust your tests on this. The forms/options behavior here was super problematic to work around. I think we should talk with @billyvg / @lynnagara about removing our duplicate form components and maybe standardizing using Formik.

.nvmrc Outdated Show resolved Hide resolved
src/sentry/static/sentry/app/options.jsx Outdated Show resolved Hide resolved
@BYK BYK requested a review from billyvg June 18, 2019 20:54
@BYK BYK merged commit 28d9f61 into master Jun 18, 2019
@BYK BYK deleted the fix-install-wizard branch June 18, 2019 21:22
BYK added a commit that referenced this pull request Jun 19, 2019
BYK added a commit that referenced this pull request Jun 19, 2019
@BYK BYK mentioned this pull request Jul 5, 2019
BYK added a commit that referenced this pull request Jul 5, 2019
* fix(installWizard): Fix client default values not set

Fixes #12813.
BYK added a commit that referenced this pull request Jul 5, 2019
@BYK BYK added this to the 9.1.2 milestone Jul 17, 2019
BYK added a commit that referenced this pull request Jul 22, 2019
* fix(installWizard): Fix client default values not set

Fixes #12813.
BYK added a commit that referenced this pull request Jul 22, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSN is empty
3 participants