Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): Include all of src/sentry #13743

Merged
merged 2 commits into from
Jun 20, 2019
Merged

fix(packaging): Include all of src/sentry #13743

merged 2 commits into from
Jun 20, 2019

Conversation

BYK
Copy link
Member

@BYK BYK commented Jun 19, 2019

Resolves the issue reported here:
https://forum.sentry.io/t/unable-to-configure-google-oauth-provider/6872

Will also prevent any similar issues in the future, such as
https://forum.sentry.io/t/enhancement-configs-not-found-on-latest-branches/6800

Fixes #13565.

@BYK BYK requested review from markstory and untitaker June 19, 2019 21:19
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly the semantics of MANIFEST.in are still gibberish to me, I trust you that you tested this with python setup.yp sdist or something like that

@BYK
Copy link
Member Author

BYK commented Jun 19, 2019

@untitaker here are the resources I used to understand the file as it was gibberish to me too:

I trust you that you tested this with python setup.yp sdist or something like that

Not yet. I'll test the actual issue later and then merge. Wanted to see if CI and reviews passed before spending the time :) CI already does sdist so this should be fairly safe to merge tho.

@BYK BYK merged commit b1436dc into master Jun 20, 2019
@BYK BYK deleted the include-all-the-things branch June 20, 2019 16:01
@BYK BYK mentioned this pull request Jul 5, 2019
BYK added a commit that referenced this pull request Jul 5, 2019
@BYK BYK added this to the 9.1.2 milestone Jul 17, 2019
BYK added a commit that referenced this pull request Jul 22, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemplateDoesNotExist: sentry_auth_google/configure.html During Google Auth configuration
2 participants