-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): Add TypeScript compatibility #13786
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
8a4b9d5
ref(typescript): Rewrite file in TypeScript
lynnagara de0b348
feat: Add ts-loader, Add sentry ts pkg + linting
HazAT 7be0584
feat: Make unit tests work with typescript
HazAT 9690159
feat: use typescript eslint parser instead of tslint
lynnagara 2694a24
Convert React component to TypeScript
lynnagara b7ef05d
Remove optional chaining
lynnagara 264fdf1
Fix/suppress lint errors in React component
lynnagara 4289274
Fix linting issues
lynnagara 412a35b
Update col type
lynnagara 6170758
space.jsx => space.tsx
dashed ab8c2e2
improve InlineSvg types
dashed 14d7349
add react types
dashed cc20da3
feat: Convert aggregation.jsx => tsx
HazAT 05a0982
feat: Convert conditions to typescript
HazAT 57218a1
fix: Missing type
HazAT 620ef4d
update snapshots
dashed b8c8e89
feat: theme.jsx => theme.tsx
dashed 1299538
feat: chartPalette.jsx => chartPalette.tsx
dashed 7f68f44
fix theme.tsx
dashed 08f4539
Turn on esmodule interop
lynnagara f229f86
Fix unnecessary imports
lynnagara e8bf36c
Fix types
lynnagara db67d66
migration pagination component
lynnagara 670775b
feat(typescript): Convert querBuilder to TypeScript
lynnagara 6bf7650
ref: Convert more Discover code to TypeScript
lynnagara 86c240a
ref: visualizationsToggle.jsx -> visualizationsToggle.tsx
lynnagara c120373
ref: Convert Discover result index page to TypeScript
lynnagara 52b02f6
ref: Convert ResultTable component to TypeScript
lynnagara 36f0a62
feat: Convert sidebar to typescript
HazAT 92d5aed
feat: Intro to tsx
HazAT b7a6b08
update snapshots
dashed 2484595
Convert more Discover code to TS
lynnagara 14f37c0
Convert last Discover file to TS
lynnagara d021345
Better aggregation and condition types
lynnagara 2e10e31
Update types
lynnagara 10c3297
More types
lynnagara cac81a7
Better types
lynnagara f78a2aa
restore InlineeSvg proptypes
dashed b28077e
inlinesvg.jsx
dashed 4d33c10
update snapshots
dashed 4dac74d
adjust tsconfig
dashed 5f20c53
adjustments
dashed 4f9f0e8
tsconfig docs
dashed f12067e
fix
dashed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...sentry/static/sentry/app/styles/space.jsx → ...sentry/static/sentry/app/styles/space.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HazAT Do you know if/why these need to be dependencies? Would be really nice to move these to devDependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. I thought we need this since we do different stuff if you call
make develop
oryarn install
.make develop
apparently on installsdependencies
wherebyyarn install
installs all.So if you do a prod build it would fail because of missing types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks for the explanation