Release 9.1.2

MANIFEST.in

@@ -1,10 +1,4 @@
-include setup.py src/sentry/assets.json README.rst MANIFEST.in LICENSE AUTHORS
-include src/sentry/loader/_registry.json
+include setup.py README.rst MANIFEST.in LICENSE AUTHORS
 recursive-include ./ requirements*.txt
-recursive-include src/sentry/templates *
-recursive-include src/sentry/locale *
-recursive-include src/sentry/data *
-recursive-include src/sentry/static/sentry *
-recursive-include src/sentry/scripts *.lua
-recursive-include src/sentry/integration-docs *.json
+graft src/sentry
 global-exclude *~

package.json

@@ -55,7 +55,7 @@
     "mobx": "^3.2.2",
     "mobx-react": "^4.2.2",
     "moment": "2.23.0",
-    "moment-timezone": "0.5.23",
+    "moment-timezone": "0.5.25",
     "node-libs-browser": "0.5.3",
     "optimize-css-assets-webpack-plugin": "^5.0.1",
     "papaparse": "^4.6.0",

requirements-base.txt

@@ -38,7 +38,7 @@ percy>=1.1.2
 petname>=2.0,<2.1
 Pillow>=3.2.0,<=4.2.1
 progressbar2>=3.10,<3.11
-psycopg2>=2.6.0,<2.8.0
+psycopg2-binary>=2.6.0,<2.8.0
 PyJWT>=1.5.0,<1.6.0
 pytest-django>=2.9.1,<2.10.0
 pytest-html>=1.9.0,<1.10.0

setup.py

@@ -97,20 +97,20 @@ class SentrySDistCommand(SDistCommand):
 
 class SentryBuildCommand(BuildCommand):
     def run(self):
-        BuildCommand.run(self)
         if not IS_LIGHT_BUILD:
             self.run_command('build_integration_docs')
             self.run_command('build_assets')
             self.run_command('build_js_sdk_registry')
+        BuildCommand.run(self)
 
 
 class SentryDevelopCommand(DevelopCommand):
     def run(self):
-        DevelopCommand.run(self)
         if not IS_LIGHT_BUILD:
             self.run_command('build_integration_docs')
             self.run_command('build_assets')
             self.run_command('build_js_sdk_registry')
+        DevelopCommand.run(self)
 
 
 cmdclass = {

src/sentry/api/endpoints/broadcast_index.py

@@ -152,7 +152,7 @@ def post(self, request):
                 message=result['message'],
                 link=result['link'],
                 is_active=result.get('isActive') or False,
-                date_expires=result.get('expiresAt'),
+                date_expires=result.get('dateExpires'),
             )
             logger.info('broadcasts.create', extra={
                 'ip_address': request.META['REMOTE_ADDR'],

src/sentry/api/endpoints/debug_files.py

@@ -337,7 +337,7 @@ def post(self, request, project):
 
             # We don't have a state yet, this means we can now start
             # an assemble job in the background.
-            set_assemble_status(project, checksum, state)
+            set_assemble_status(project, checksum, ChunkFileState.CREATED)
             assemble_dif.apply_async(
                 kwargs={
                     'project_id': project.id,

src/sentry/api/endpoints/organization_release_details.py

@@ -1,21 +1,14 @@
 from __future__ import absolute_import
 
-from rest_framework import serializers
 from rest_framework.response import Response
 
 from sentry.api.base import DocSection
 from sentry.api.bases.organization import OrganizationReleasesBaseEndpoint
 from sentry.api.exceptions import InvalidRepository, ResourceDoesNotExist
 from sentry.api.serializers import serialize
-from sentry.api.serializers.rest_framework import (
-    CommitSerializer,
-    ListField,
-    ReleaseHeadCommitSerializerDeprecated,
-    ReleaseHeadCommitSerializer,
-)
+from sentry.api.serializers.rest_framework import ListField, ReleaseSerializer, ReleaseHeadCommitSerializer, ReleaseHeadCommitSerializerDeprecated
 from sentry.models import Activity, Group, Release, ReleaseFile
 from sentry.utils.apidocs import scenario, attach_scenarios
-from sentry.constants import VERSION_LENGTH
 
 ERR_RELEASE_REFERENCED = "This release is referenced by active issues and cannot be removed."
 
@@ -41,13 +34,11 @@ def update_organization_release_scenario(runner):
     )
 
 
-class ReleaseSerializer(serializers.Serializer):
-    ref = serializers.CharField(max_length=VERSION_LENGTH, required=False)
-    url = serializers.URLField(required=False)
-    dateReleased = serializers.DateTimeField(required=False)
-    commits = ListField(child=CommitSerializer(), required=False, allow_null=False)
+class OrganizationReleaseSerializer(ReleaseSerializer):
     headCommits = ListField(
-        child=ReleaseHeadCommitSerializerDeprecated(), required=False, allow_null=False
+        child=ReleaseHeadCommitSerializerDeprecated(),
+        required=False,
+        allow_null=False
     )
     refs = ListField(
         child=ReleaseHeadCommitSerializer(),
@@ -129,7 +120,7 @@ def put(self, request, organization, version):
         if not self.has_release_permission(request, organization, release):
             raise ResourceDoesNotExist
 
-        serializer = ReleaseSerializer(data=request.DATA)
+        serializer = OrganizationReleaseSerializer(data=request.DATA)
 
         if not serializer.is_valid():
             return Response(serializer.errors, status=400)

src/sentry/api/endpoints/organization_releases.py

@@ -5,14 +5,13 @@
 from rest_framework.response import Response
 
 from sentry.api.bases import NoProjects, OrganizationEventsError
-from .project_releases import ReleaseSerializer
 from sentry.api.base import DocSection, EnvironmentMixin
 from sentry.api.bases.organization import OrganizationReleasesBaseEndpoint
 from sentry.api.exceptions import InvalidRepository
 from sentry.api.paginator import OffsetPaginator
 from sentry.api.serializers import serialize
 from sentry.api.serializers.rest_framework import (
-    ReleaseHeadCommitSerializer, ReleaseHeadCommitSerializerDeprecated, ListField
+    ReleaseHeadCommitSerializer, ReleaseHeadCommitSerializerDeprecated, ReleaseWithVersionSerializer, ListField
 )
 from sentry.models import Activity, Release
 from sentry.signals import release_created
@@ -64,12 +63,12 @@ def list_org_releases_scenario(runner):
     runner.request(method='GET', path='/organizations/%s/releases/' % (runner.org.slug, ))
 
 
-class ReleaseSerializerWithProjects(ReleaseSerializer):
+class ReleaseSerializerWithProjects(ReleaseWithVersionSerializer):
     projects = ListField()
     headCommits = ListField(
         child=ReleaseHeadCommitSerializerDeprecated(),
         required=False,
-        allow_null=False,
+        allow_null=False
     )
     refs = ListField(
         child=ReleaseHeadCommitSerializer(),

src/sentry/api/endpoints/project_release_details.py

@@ -1,24 +1,17 @@
 from __future__ import absolute_import
 
-from rest_framework import serializers
 from rest_framework.response import Response
 
 from sentry.api.bases.project import ProjectEndpoint, ProjectReleasePermission
 from sentry.api.exceptions import ResourceDoesNotExist
 from sentry.api.serializers import serialize
-from sentry.api.serializers.rest_framework import CommitSerializer, ListField
+from sentry.api.serializers.rest_framework import ReleaseSerializer
+
 from sentry.models import Activity, Group, Release, ReleaseFile
 from sentry.plugins.interfaces.releasehook import ReleaseHook
-from sentry.constants import VERSION_LENGTH
-
-ERR_RELEASE_REFERENCED = "This release is referenced by active issues and cannot be removed."
 
 
-class ReleaseSerializer(serializers.Serializer):
-    ref = serializers.CharField(max_length=VERSION_LENGTH, required=False)
-    url = serializers.URLField(required=False)
-    dateReleased = serializers.DateTimeField(required=False)
-    commits = ListField(child=CommitSerializer(), required=False, allow_null=False)
+ERR_RELEASE_REFERENCED = "This release is referenced by active issues and cannot be removed."
 
 
 class ProjectReleaseDetailsEndpoint(ProjectEndpoint):

src/sentry/api/endpoints/project_releases.py

@@ -2,64 +2,22 @@
 
 from django.db import IntegrityError, transaction
 
-from rest_framework import serializers
 from rest_framework.response import Response
 
 from sentry.api.base import EnvironmentMixin
 from sentry.api.bases.project import ProjectEndpoint, ProjectReleasePermission
 from sentry.api.paginator import OffsetPaginator
-from sentry.api.fields.user import UserField
 from sentry.api.serializers import serialize
-from sentry.api.serializers.rest_framework import CommitSerializer, ListField
+from sentry.api.serializers.rest_framework import ReleaseWithVersionSerializer
 from sentry.models import (
     Activity,
-    CommitFileChange,
     Environment,
     Release,
 )
 from sentry.plugins.interfaces.releasehook import ReleaseHook
-from sentry.constants import VERSION_LENGTH
 from sentry.signals import release_created
 
 
-class CommitPatchSetSerializer(serializers.Serializer):
-    path = serializers.CharField(max_length=255)
-    type = serializers.CharField(max_length=1)
-
-    def validate_type(self, attrs, source):
-        value = attrs[source]
-        if not CommitFileChange.is_valid_type(value):
-            raise serializers.ValidationError('Commit patch_set type %s is not supported.' % value)
-        return attrs
-
-
-class CommitSerializerWithPatchSet(CommitSerializer):
-    patch_set = ListField(
-        child=CommitPatchSetSerializer(
-            required=False),
-        required=False,
-        allow_null=True)
-
-
-class ReleaseSerializer(serializers.Serializer):
-    version = serializers.CharField(max_length=VERSION_LENGTH, required=True)
-    ref = serializers.CharField(max_length=VERSION_LENGTH, required=False)
-    url = serializers.URLField(required=False)
-    owner = UserField(required=False)
-    dateReleased = serializers.DateTimeField(required=False)
-    commits = ListField(
-        child=CommitSerializerWithPatchSet(
-            required=False),
-        required=False,
-        allow_null=True)
-
-    def validate_version(self, attrs, source):
-        value = attrs[source]
-        if not Release.is_valid_version(value):
-            raise serializers.ValidationError('Invalid value for release')
-        return attrs
-
-
 class ProjectReleasesEndpoint(ProjectEndpoint, EnvironmentMixin):
     permission_classes = (ProjectReleasePermission, )
 
@@ -146,7 +104,7 @@ def post(self, request, project):
                                       the current time is assumed.
         :auth: required
         """
-        serializer = ReleaseSerializer(data=request.DATA)
+        serializer = ReleaseWithVersionSerializer(data=request.DATA)
 
         if serializer.is_valid():
             result = serializer.object

src/sentry/api/serializers/models/pullrequest.py

@@ -36,9 +36,12 @@ def get_attrs(self, item_list, user):
         result = {}
         for item in item_list:
             repository_id = six.text_type(item.repository_id)
+            external_url = ''
+            if item.repository_id in repository_map:
+                external_url = self._external_url(repository_map[item.repository_id], item)
             result[item] = {
                 'repository': serialized_repos.get(repository_id, {}),
-                'external_url': self._external_url(repository_map[item.repository_id], item),
+                'external_url': external_url,
                 'user': users_by_author.get(six.text_type(item.author_id), {})
                 if item.author_id else {},
             }

src/sentry/api/serializers/rest_framework/commit.py

@@ -1,6 +1,19 @@
 from __future__ import absolute_import
 
 from rest_framework import serializers
+from sentry.api.serializers.rest_framework.list import ListField
+from sentry.models import CommitFileChange
+
+
+class CommitPatchSetSerializer(serializers.Serializer):
+    path = serializers.CharField(max_length=255)
+    type = serializers.CharField(max_length=1)
+
+    def validate_type(self, attrs, source):
+        value = attrs[source]
+        if not CommitFileChange.is_valid_type(value):
+            raise serializers.ValidationError('Commit patch_set type %s is not supported.' % value)
+        return attrs
 
 
 class CommitSerializer(serializers.Serializer):
@@ -10,3 +23,8 @@ class CommitSerializer(serializers.Serializer):
     author_name = serializers.CharField(max_length=128, required=False)
     author_email = serializers.EmailField(max_length=75, required=False)
     timestamp = serializers.DateTimeField(required=False)
+    patch_set = ListField(
+        child=CommitPatchSetSerializer(required=False),
+        required=False,
+        allow_null=True,
+    )

src/sentry/api/serializers/rest_framework/release.py

@@ -0,0 +1,38 @@
+from __future__ import absolute_import
+
+from rest_framework import serializers
+
+from sentry.api.serializers.rest_framework import CommitSerializer, ListField
+from sentry.api.fields.user import UserField
+from sentry.constants import VERSION_LENGTH
+from sentry.models import Release
+
+
+class ReleaseHeadCommitSerializerDeprecated(serializers.Serializer):
+    currentId = serializers.CharField(max_length=64)
+    repository = serializers.CharField(max_length=64)
+    previousId = serializers.CharField(max_length=64, required=False)
+
+
+class ReleaseHeadCommitSerializer(serializers.Serializer):
+    commit = serializers.CharField(max_length=64)
+    repository = serializers.CharField(max_length=200)
+    previousCommit = serializers.CharField(max_length=64, required=False)
+
+
+class ReleaseSerializer(serializers.Serializer):
+    ref = serializers.CharField(max_length=VERSION_LENGTH, required=False)
+    url = serializers.URLField(required=False)
+    dateReleased = serializers.DateTimeField(required=False)
+    commits = ListField(child=CommitSerializer(), required=False, allow_null=False)
+
+
+class ReleaseWithVersionSerializer(ReleaseSerializer):
+    version = serializers.CharField(max_length=VERSION_LENGTH, required=True)
+    owner = UserField(required=False)
+
+    def validate_version(self, attrs, source):
+        value = attrs[source]
+        if not Release.is_valid_version(value):
+            raise serializers.ValidationError('Release with name %s is not allowed' % value)
+        return attrs

src/sentry/conf/server.py

@@ -1606,3 +1606,8 @@ def get_sentry_sdk_config():
         'topic': KAFKA_EVENTS,
     },
 }
+
+# Enable this to use the legacy Slack Workspace Token apps. You will likely
+# never need to switch this unless you created a workspace app before slack
+# disabled them.
+SLACK_INTEGRATION_USE_WST = False