Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ts): webpack file-loader compatibility for TS #14387

Merged
merged 1 commit into from
Aug 14, 2019
Merged

chore(ts): webpack file-loader compatibility for TS #14387

merged 1 commit into from
Aug 14, 2019

Conversation

dashed
Copy link
Member

@dashed dashed commented Aug 14, 2019

Ref: microsoft/TypeScript-React-Starter#12 (comment)

Some files import *.png files, which works with webpack's file-loader; but confuses TypeScript.

We provide .d.ts types for these files.

@dashed dashed requested a review from a team August 14, 2019 15:21
@dashed dashed self-assigned this Aug 14, 2019
evanpurkhiser
evanpurkhiser approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@dashed dashed merged commit d88bf68 into master Aug 14, 2019
@dashed dashed deleted the typescript/fileloader branch August 14, 2019 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees

@dashed dashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashed @evanpurkhiser