feat: Flip sampling defaults to false #14627
Conversation
This only affects open source users as "projects:sample-events" should already always be false for all SaaS users on sentry.io. We should follow up by removing all of the associated sampling code.
| @@ -881,7 +881,7 @@ def create_partitioned_queues(name): | |||
| # Enable functionality for rate-limiting events on projects. | |||
| "projects:rate-limits": True, | |||
| # Enable functionality for sampling of events on projects. | |||
| "projects:sample-events": True, | |||
| "projects:sample-events": False, | |||
There was a problem hiding this comment.
Do we need to retain this feature switch if its not used on saas?
There was a problem hiding this comment.
It's still being referenced right now, will remove it together with the code
|
Technically someone using the open source version may still be relying on this. Do we need to communicate it before removing the feature ? |
|
@BYK Do you have any thoughts on this? For any open source users who are running Snuba / 10.x sampling probably hasn't worked as expected for quite a while. |
|
Thanks for the heads up @lynnagara! We've already turned this off for v10 onpremise per @jan-auer's suggestion earlier: https://github.com/getsentry/onpremise/pull/220/files#diff-66f7c6c9e9f860724fb428123754dbaaR183 |
|
It sounds like we don't need to communicate anything extra then. Since the feature is already kind of broken and we're removing it soon we could probably go ahead and take it out of the docs then to avoid any confusion. getsentry/sentry-docs#1216 |
This only affects open source users as "projects:sample-events"
should already always be false for all SaaS users on sentry.io.
We should follow up by removing all of the associated sampling code.