Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): Add timeOrigin tags #24901

Merged
merged 1 commit into from
Apr 14, 2021
Merged

feat(sdk): Add timeOrigin tags #24901

merged 1 commit into from
Apr 14, 2021

Conversation

wmak
Copy link
Member

@wmak wmak commented Apr 1, 2021 •
edited
Loading

@wmak wmak requested a review from a team as a code owner April 1, 2021 16:26
@wmak wmak requested a review from rhcarvalho April 1, 2021 16:27
@billyvg
Copy link
Member

billyvg commented Apr 1, 2021

cc @lobsterkatie

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021 •
edited
Loading

size-limit report

Path Base Size (c483ddd) Current Size Change
public/app.js 336.16 KB 336.22 KB +0.02% 🔺
public/vendor.js 588.91 KB 588.94 KB +0.01% 🔺
public/sentry.css 23.81 KB 23.81 KB 0%

rhcarvalho
rhcarvalho approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about yarn.lock, but the rest looks good 👍

@wmak wmak changed the title feat(sdk): Update the sentry sdk feat(sdk): Add timeOrigin tags Apr 13, 2021
@wmak wmak removed the request for review from a team April 13, 2021 14:41
@wmak
Copy link
Member Author

wmak commented Apr 13, 2021 •
edited
Loading

@rhcarvalho just as a btw, waiting on #25217 first to get 6.3.0-beta.6

@wmak
feat(sdk): Add a timeOrigin.mode tag
5138210 
- This is so we can track how often we're changing timeOrigin to get a
  better calculation
@wmak wmak merged commit eac3d1e into master Apr 14, 2021
@wmak wmak deleted the wmak/feat/timeorigin-sdk branch April 14, 2021 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmak @billyvg @rhcarvalho