Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(breakdowns): Rename keys in span operation breakdown config #26604

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

dashed
Copy link
Member

@dashed dashed commented Jun 14, 2021

To be merged after getsentry/relay#1020

TODO

  • add one E2E test to tests/relay_integration/ that ingests a transaction, and then check for the computed operations breakdown

@dashed dashed requested review from untitaker and a team June 14, 2021 21:17
@dashed dashed self-assigned this Jun 14, 2021
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add one E2E test to tests/relay_integration/ that ingests a transaction and then checks for the breakdown? It should pass after merging the Relay changes.

@dashed
Copy link
Member Author

dashed commented Jun 16, 2021

@jan-auer I've added one E2E test 😄

@dashed dashed force-pushed the rename-ops-breakdown-config branch from d0bc37c to a318b56 Compare June 16, 2021 17:24
@dashed dashed merged commit 9d4aa03 into master Jun 16, 2021
@dashed dashed deleted the rename-ops-breakdown-config branch June 16, 2021 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants