Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(perf): Add basic interaction for Performance@Sentry #33463

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Apr 8, 2022

Summary

Adding the basics of interactions to monitor an area we observed to have some poor performance interaction-wise. Holds onto interactions in a static since we currently don't support multiple ongoing transactions, manually will close an idle transaction from pageload since interactions would indicate pageload has finished.

Screenshots

Screen Shot 2022-04-08 at 12 33 37 PM

Collecting long tasks, and the specifically wrapped components so we know that the SpanTree component is causing most of the longtask / render time. Below we can also see an error in the console that relates to SpanTree having duplicate key which might be something to look into for performance.

Other

  • Made a simple api startInteraction + finishInteraction. Start interaction should automatically wrap up with a timeout of 2 minutes (some interactions can be quite long).
  • This code is all auxiliary and experimental, hence the try/catches around all call-sites and the lack of tests for these functions.
  • There is no current intent of porting this to work with our sdks, since our requirements are a lot less stringent than what would be required to make a generic approach, but hopefully when it comes time this code can serve as a starting point at least.

Adding the basics of interactions to monitor an area we observed to have some poor performance interaction-wise. Holds onto interactions in a static since we currently don't support multiple ongoing transactions, manually will close an idle transaction from pageload since interactions would indicate pageload has finished.
@k-fish k-fish requested a review from a team as a code owner April 8, 2022 17:19
@k-fish k-fish requested review from AbhiPrasad and Zylphrex April 8, 2022 17:20
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 61.25 KB (-0.02% 🔽)
src/sentry/static/sentry/dist/entrypoints/sentry.css 69.97 KB (0%)

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k-fish k-fish enabled auto-merge (squash) April 8, 2022 17:39
@k-fish k-fish merged commit cb06256 into master Apr 8, 2022
@k-fish k-fish deleted the ref/perf-span-tree-timing-interactions branch April 8, 2022 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants