Skip to content

ref(perf): Add perf asset collection #36012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions static/app/utils/performanceForSentry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -309,3 +309,82 @@ export const VisuallyCompleteWithData = ({
</Profiler>
);
};

interface OpAssetMeasurementDefinition {
key: string;
}

const OP_ASSET_MEASUREMENT_MAP: Record<string, OpAssetMeasurementDefinition> = {
'resource.script': {
key: 'script',
},
'resource.css': {
key: 'css',
},
'resource.link': {
key: 'link',
},
'resource.img': {
key: 'img',
},
};
const ASSET_MEASUREMENT_ALL = 'allResources';

export const MeasureAssetsOnTransaction = ({children}: {children: ReactNode}) => {
useEffect(() => {
try {
const transaction: any = getCurrentSentryReactTransaction(); // Using any to override types for private api.
if (!transaction) {
return;
}

transaction.registerBeforeFinishCallback((t: Transaction) => {
const spans: any[] = (t as any).spanRecorder?.spans;
const measurements = (t as any)._measurements;

if (!spans) {
return;
}

if (measurements[ASSET_MEASUREMENT_ALL]) {
return;
}

let allTransfered = 0;
let allEncoded = 0;
let allCount = 0;

for (const [op, definition] of Object.entries(OP_ASSET_MEASUREMENT_MAP)) {
const filtered = spans.filter(s => s.op === op);
const count = filtered.length;
const transfered = filtered.reduce(
(acc, curr) => acc + curr.data['Transfer Size'] ?? 0,
0
);
const encoded = filtered.reduce(
(acc, curr) => acc + curr.data['Encoded Body Size'] ?? 0,
0
);

if (op === 'resource.script') {
t.setMeasurement(`assets.${definition.key}.encoded`, encoded, '');
t.setMeasurement(`assets.${definition.key}.transfer`, transfered, '');
t.setMeasurement(`assets.${definition.key}.count`, count, '');
}

allCount += count;
allTransfered += transfered;
allEncoded += encoded;
}

t.setMeasurement(`${ASSET_MEASUREMENT_ALL}.encoded`, allEncoded, '');
t.setMeasurement(`${ASSET_MEASUREMENT_ALL}.transfer`, allTransfered, '');
t.setMeasurement(`${ASSET_MEASUREMENT_ALL}.count`, allCount, '');
});
} catch (_) {
// Defensive catch since this code is auxiliary.
}
}, []);

return <Fragment>{children}</Fragment>;
};
39 changes: 21 additions & 18 deletions static/app/views/performance/content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {PageFilters, Project} from 'sentry/types';
import trackAdvancedAnalyticsEvent from 'sentry/utils/analytics/trackAdvancedAnalyticsEvent';
import {MEPSettingProvider} from 'sentry/utils/performance/contexts/metricsEnhancedSetting';
import {PerformanceEventViewProvider} from 'sentry/utils/performance/contexts/performanceEventViewContext';
import {MeasureAssetsOnTransaction} from 'sentry/utils/performanceForSentry';
import useApi from 'sentry/utils/useApi';
import useOrganization from 'sentry/utils/useOrganization';
import usePrevious from 'sentry/utils/usePrevious';
Expand Down Expand Up @@ -159,24 +160,26 @@ function PerformanceContent({selection, location, demoMode}: Props) {
},
}}
>
<PerformanceLanding
eventView={eventView}
setError={setError}
handleSearch={handleSearch}
handleTrendsClick={() =>
handleTrendsClick({
location,
organization,
projectPlatforms: getSelectedProjectPlatforms(location, projects),
})
}
onboardingProject={onboardingProject}
organization={organization}
location={location}
projects={projects}
selection={selection}
withStaticFilters={withStaticFilters}
/>
<MeasureAssetsOnTransaction>
<PerformanceLanding
eventView={eventView}
setError={setError}
handleSearch={handleSearch}
handleTrendsClick={() =>
handleTrendsClick({
location,
organization,
projectPlatforms: getSelectedProjectPlatforms(location, projects),
})
}
onboardingProject={onboardingProject}
organization={organization}
location={location}
projects={projects}
selection={selection}
withStaticFilters={withStaticFilters}
/>
</MeasureAssetsOnTransaction>
</PageFiltersContainer>
</MEPSettingProvider>
</PerformanceEventViewProvider>
Expand Down