chore(view-hierarchy): Add proguard file size to span #44826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking the file size so we can understand its impact on timing
github-actions
bot
added
the
Scope: Backend
edwardgou-sentry
approved these changes
Feb 17, 2023
src/sentry/lang/java/utils.py
Outdated
| dif_paths = ProjectDebugFile.difcache.fetch_difs(project, [uuid], features=["mapping"]) | ||
| debug_file_path = dif_paths.get(uuid) | ||
| if debug_file_path is None: | ||
| return | ||
|
|
||
| proguard_file_size_in_mb = os.path.getsize(debug_file_path) / (1024 * 1024.0) |
There was a problem hiding this comment.
Should we wrap this in a try catch just in case, even if we're confident it wont fail? I think os.path.getsize might throw an error if it cant reach the file for whatever reason
There was a problem hiding this comment.
oh good point, I'll do that. Thanks for the suggestion
jjbayer
approved these changes
Feb 20, 2023
andriisoldatenko
pushed a commit
that referenced
this pull request
Feb 21, 2023
Tracking the file size so we can understand its impact on timing
andriisoldatenko
pushed a commit
that referenced
this pull request
Feb 24, 2023
Tracking the file size so we can understand its impact on timing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking the file size so we can understand its impact on timing