Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(crons): Remove unused non-org endpoints #45183

Merged

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Feb 28, 2023

  1. The monitor details and monitor stats endpoint had additional org-less routes that were legacy from when this feature was first built.

  2. The attachments endpoint was just named wrong

I've verified these endpoints are not being used with the following query

SELECT
  COUNT(*),
  jsonPayload.path
FROM
  `internal-sentry.getsentry_api_access_logs.stderr`
WHERE
  DATE(timestamp) = "2023-02-01"
  AND jsonPayload.view IN ('sentry.api.endpoints.monitor_stats.MonitorStatsEndpoint', 'sentry.api.endpoints.monitor_details.MonitorDetailsEndpoint')
  and NOT CONTAINS_SUBSTR(jsonPayload.path, 'organization')
GROUP BY
  2
ORDER BY
  1 desc

which returns no results

This is in support of #45166

@evanpurkhiser evanpurkhiser requested review from a team as code owners February 28, 2023 04:29
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team February 28, 2023 04:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 28, 2023
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-unused-non-org-endpoints branch from 661bc81 to 40eeae0 Compare February 28, 2023 04:30
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-unused-non-org-endpoints branch from 40eeae0 to f99c8e2 Compare February 28, 2023 05:01
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-unused-non-org-endpoints branch from f99c8e2 to 6411cb5 Compare February 28, 2023 05:22
1. The monitor details and monitor stats endpoint had additional
   org-less routes that were legacy from when this feature was first
   built.

 2. The attachments endpoint was just named wrong
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-unused-non-org-endpoints branch from 6411cb5 to 2b9a832 Compare February 28, 2023 08:38
@evanpurkhiser evanpurkhiser merged commit f65f167 into master Feb 28, 2023
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-remove-unused-non-org-endpoints branch February 28, 2023 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants