Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Migrate guid to slug #45270

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

evanpurkhiser
Copy link
Member

Backfills all of the new slugs for existing monitors

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner March 1, 2023 21:34
@evanpurkhiser evanpurkhiser requested review from rjo100 and a team and removed request for a team March 1, 2023 21:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

This PR has a migration; here is the generated SQL for src/sentry/migrations/0367_migrate_monitor_guid_to_slug.py ()

--
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
--

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #45270 (fa6311c) into master (b761568) will decrease coverage by 5.87%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #45270      +/-   ##
==========================================
- Coverage   74.42%   68.55%   -5.87%     
==========================================
  Files        4700     4695       -5     
  Lines      198544   198404     -140     
  Branches    12022    12022              
==========================================
- Hits       147757   136008   -11749     
- Misses      50525    62134   +11609     
  Partials      262      262              
Impacted Files Coverage Δ
src/sentry/tasks/integrations/migrate_issues.py 17.77% <0.00%> (-80.00%) ⬇️
src/sentry/web/frontend/oauth_authorize.py 15.38% <0.00%> (-77.70%) ⬇️
src/sentry/testutils/helpers/query.py 21.05% <0.00%> (-73.69%) ⬇️
src/sentry/lang/java/processing.py 27.27% <0.00%> (-72.73%) ⬇️
...rc/sentry/api/endpoints/project_stacktrace_link.py 16.83% <0.00%> (-71.94%) ⬇️
src/sentry/db/deletion.py 12.50% <0.00%> (-71.25%) ⬇️
...sentry/mediators/sentry_app_components/preparer.py 27.41% <0.00%> (-70.97%) ⬇️
src/sentry/lang/java/plugin.py 25.00% <0.00%> (-70.24%) ⬇️
src/sentry/deletions/defaults/organization.py 30.00% <0.00%> (-70.00%) ⬇️
src/sentry/integrations/msteams/webhook.py 23.75% <0.00%> (-69.74%) ⬇️
... and 694 more

@evanpurkhiser evanpurkhiser merged commit 8514418 into master Mar 1, 2023
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-crons-migrate-guid-to-slug branch March 1, 2023 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants