fix(inbound-filter): Fix react hydration errors message condition #45364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
jan-auer
approved these changes
Mar 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45364 +/- ##
==========================================
- Coverage 80.23% 77.02% -3.22%
==========================================
Files 4724 4720 -4
Lines 198817 198688 -129
Branches 12006 12006
==========================================
- Hits 159529 153045 -6484
- Misses 39026 45381 +6355
Partials 262 262
|
jjbayer
approved these changes
Mar 3, 2023
RaduW
previously requested changes
Mar 3, 2023
| @@ -125,7 +125,7 @@ def get_filter_settings(project: Project) -> Mapping[str, Any]: | |||
| # 423 - There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering. | |||
| # 425 - Text content does not match server-rendered HTML. | |||
| error_messages += [ | |||
| "https://reactjs.org/docs/error-decoder.html?invariant={418,419,422,423,425}" | |||
There was a problem hiding this comment.
Is this a regex ?
If it is a regex I don't think it is correct
if you want to select "https://..... =" followed by one of the numbers than you would need something like:
https://reactjs.org/docs/error-decoder.html\?invariant=(418|419|422|423|425){1}
which in python you can write as:
# normal string
error_message = "https://reactjs.org/docs/error-decoder.html\\?invariant=(418|419|422|423|425){1}"
# raw string (no double backslash)
error_message = r"https://reactjs.org/docs/error-decoder.html\?invariant=(418|419|422|423|425){1}"
There was a problem hiding this comment.
I tested it with Joris in Rust and it works
There was a problem hiding this comment.
It's a glob, not a regex.
priscilawebdev
deleted the
fix/inbound-filters-fix-react-hydration-errors-message-condition
branch
jjbayer
added a commit
to getsentry/relay
that referenced
this pull request
Mar 3, 2023
Unit test for getsentry/sentry#45364.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay was not filtering out react hydration errors events because the relay message condition didn't contain
*message*This PR fixes the issue.
Related to #45188