Skip to content

Conversation

@lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner March 22, 2023 17:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 22, 2023
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume make freeze-requirements will run by itself or CI will force you to do it... but this is not actually the full changeset required for bumping deps. you need to run that command to update the "lockfile"/"frozenfile"

@untitaker
Copy link
Member

For context this is a required bump so we can use sentry-kafka-schemas's autogenerated types effectively.

@lynnagara lynnagara enabled auto-merge (squash) March 22, 2023 17:54
@lynnagara lynnagara merged commit 8ad22e7 into master Mar 22, 2023
@lynnagara lynnagara deleted the bump-typing-extensions branch March 22, 2023 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants