Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transactions): Sync cursor hover between minimap and CPU chart #46814

Merged
merged 10 commits into from
Apr 4, 2023
Merged

feat(transactions): Sync cursor hover between minimap and CPU chart #46814

merged 10 commits into from
Apr 4, 2023

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Apr 3, 2023 •
edited
Loading

Synchronizes the cursor between the span tree minimap and the CPU chart.

Screen.Recording.2023-04-03.at.3.26.57.PM.mov

Depends on #46676 as the base for adding this chart
Closes #46686

@narsaynorath narsaynorath requested a review from a team April 3, 2023 19:28
@narsaynorath narsaynorath requested a review from a team as a code owner April 3, 2023 19:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2023
Base automatically changed from nar/feat/transactions-cpu-chart to master April 4, 2023 15:57
@narsaynorath narsaynorath requested review from a team as code owners April 4, 2023 15:57
@narsaynorath narsaynorath removed request for a team April 4, 2023 16:55
@narsaynorath narsaynorath merged commit fdaeae3 into master Apr 4, 2023
@narsaynorath narsaynorath deleted the nar/feat/transaction-cpu-sync-cursor-hover branch April 4, 2023 19:45
schew2381 pushed a commit that referenced this pull request Apr 12, 2023
@narsaynorath @schew2381
feat(transactions): Sync cursor hover between minimap and CPU chart (#…
24a2c35 
…46814)

Synchronizes the cursor between the span tree minimap and the CPU chart.

Closes #46686
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edwardgou-sentry edwardgou-sentry edwardgou-sentry approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronize hover cursor across minimap and CPU chart
2 participants
@narsaynorath @edwardgou-sentry