ref(replays): remove unused chunking code #47877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47877 +/- ##
==========================================
+ Coverage 78.29% 80.81% +2.52%
==========================================
Files 4762 4762
Lines 201354 201285 -69
Branches 11594 11594
==========================================
+ Hits 157644 162667 +5023
+ Misses 43454 38362 -5092
Partials 256 256
|
cmanallen
requested changes
May 1, 2023
| with metrics.timer("replays.process_recording.store_recording.drop_segments"): | ||
| parts.drop() | ||
|
|
||
|
|
||
| @metrics.wraps("replays.usecases.ingest.ingest_recording_not_chunked") | ||
| def ingest_recording_not_chunked( |
There was a problem hiding this comment.
This should be renamed to ingest_recording. The other ingest_recording function can be renamed to _ingest_recording or merged into the body of this function.
| def move_chunks_to_cache_or_skip(message: Message[KafkaPayload]) -> MessageContext: | ||
| """Move chunk messages to cache or skip.""" | ||
| def initialize_message_context(message: Message[KafkaPayload]) -> MessageContext: | ||
| """initialize a Sentry transaction and unpack the message.""" |
cmanallen
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging getsentry/relay#2032, we've observed that we are no longer processing chunked messages (as intended). We can remove the logic for this as it is no longer used.