Skip to content

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Feb 4, 2017

This pull request adds reprocessing support to the system. So far this feature is only enabled for native symbol processing.

Project Settings UI

screen shot 2017-02-09 at 16 08 02

Different Stream Details

screen shot 2017-02-09 at 16 05 40

screen shot 2017-02-09 at 16 06 55

screen shot 2017-02-09 at 16 07 11

@HazAT
Copy link
Member

HazAT commented Feb 10, 2017

https://facebook.github.io/react/docs/uncontrolled-components.html#default-values
You are right ... If I should change it I would have to initalize the whole processing issues jsx file to receive the form values upfront.

@mitsuhiko
Copy link
Contributor Author

Since this has the change to break other stuff, what if we just make it a button to turn on/off for now?

Copy link
Contributor

@JTCunning JTCunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few things that should probably spark either change or conversation, but nothing blocking.

delete_raw_event(project, event_id)
data = default_cache.get(cache_key)
if data is None:
metrics.incr('events.failed', tags={'reason': 'cache', 'stage': 'failed_raw'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics.incr('events.failed', tags={'reason': 'cache', 'stage': 'raw'})

Queue('digests.scheduling', routing_key='digests.scheduling'),
Queue('email', routing_key='email'),
Queue('events.preprocess_event', routing_key='events.preprocess_event'),
Queue('events.preprocess_event_from_reprocessing',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be inclined to rename this queue and the ones below to:

events.reprocess.preprocess_event
events.reprocess.process_event
events.reprocess.schedule

Seems a little more fitting of description for me.

@mitsuhiko
Copy link
Contributor Author

I think as it stands right now this might be ready to review and then merge.

@mikepurvis
Copy link

This change is going to be huge for enabling custom crash reporters.

@HazAT
Copy link
Member

HazAT commented Feb 17, 2017

screenshot 2017-02-17 17 53 56

Copy link
Contributor

@JTCunning JTCunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burn it all down.

@mitsuhiko mitsuhiko merged commit d41eafa into master Feb 23, 2017
@mitsuhiko mitsuhiko deleted the feature/new-reprocessing branch February 23, 2017 19:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants