-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Event Reprocessing / Processing Issues #4867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
https://facebook.github.io/react/docs/uncontrolled-components.html#default-values |
|
Since this has the change to break other stuff, what if we just make it a button to turn on/off for now? |
JTCunning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few things that should probably spark either change or conversation, but nothing blocking.
src/sentry/tasks/store.py
Outdated
| delete_raw_event(project, event_id) | ||
| data = default_cache.get(cache_key) | ||
| if data is None: | ||
| metrics.incr('events.failed', tags={'reason': 'cache', 'stage': 'failed_raw'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metrics.incr('events.failed', tags={'reason': 'cache', 'stage': 'raw'})
src/sentry/conf/server.py
Outdated
| Queue('digests.scheduling', routing_key='digests.scheduling'), | ||
| Queue('email', routing_key='email'), | ||
| Queue('events.preprocess_event', routing_key='events.preprocess_event'), | ||
| Queue('events.preprocess_event_from_reprocessing', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be inclined to rename this queue and the ones below to:
events.reprocess.preprocess_event
events.reprocess.process_event
events.reprocess.schedule
Seems a little more fitting of description for me.
|
I think as it stands right now this might be ready to review and then merge. |
|
This change is going to be huge for enabling custom crash reporters. |
JTCunning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Burn it all down.

This pull request adds reprocessing support to the system. So far this feature is only enabled for native symbol processing.
Project Settings UI
Different Stream Details