Network Error Logging: backend part #55135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
Codecov Report
@@ Coverage Diff @@
## master #55135 +/- ##
=======================================
Coverage 80.75% 80.76%
=======================================
Files 5171 5174 +3
Lines 226919 226961 +42
Branches 38149 38160 +11
=======================================
+ Hits 183253 183309 +56
+ Misses 38111 38096 -15
- Partials 5555 5556 +1
|
No product doc for now, I'd prefer to release this internally and try this on our own org. Then we can promote it, etc.
For now, grouping will be default by message (for example,
There is no need to touch SDKs, since NEL is a feature implemented on the browser side. The idea is similar to CSP in this sense. |
oioki
added a commit
to getsentry/relay
that referenced
this pull request
Nov 6, 2023
The first part of the NEL ([Network Error Logging](https://developer.mozilla.org/en-US/docs/Web/HTTP/Network_Error_Logging)) implementation. * Adds a new `Nel` EventType * Adds a new `Nel` protocol with minimal validation (i.e. only specific fields are captured) * Adds a new `/api/:project_id/nel/` endpoint for NEL reports ingestion * simple content type validation * splits payload into separate envelopes (a single HTTP NEL request could contain several independent reports) * `user.ip_address` field is set to the IP address of the request (real user's IP address) * An event is enriched with browser information derived from the request's `User-Agent` header Related PRs: getsentry/sentry#55135 getsentry/sentry-kafka-schemas#177 --------- Co-authored-by: Oleksandr Kylymnychenko <oleksandr@sentry.io> Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com> Co-authored-by: Jan Michael Auer <mail@jauer.org>
jjbayer
approved these changes
Nov 9, 2023
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry backend part of the NEL (Network Error Logging) implementation.
nelevent type and interfaceTo be deployed after merging Relay part (getsentry/relay#2421) and releasing
sentry-relaypython package.