Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(am2): Add bun as am2 compat SDK #56913

Merged
merged 2 commits into from
Sep 26, 2023
Merged

feat(am2): Add bun as am2 compat SDK #56913

merged 2 commits into from
Sep 26, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 26, 2023 •
edited
Loading

ref #56856

See getsentry/sentry-javascript#9042 and https://docs.sentry.io/platforms/javascript/guides/bun/

Bun inherits directly from our Node SDK, so is good to go for am2 :)

@AbhiPrasad AbhiPrasad mentioned this pull request Sep 26, 2023
Closed
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 26, 2023
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner September 26, 2023 03:01
iambriccardo
iambriccardo approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for adding this @AbhiPrasad

@AbhiPrasad AbhiPrasad merged commit d52af95 into master Sep 26, 2023
49 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-bun-am2-compat branch September 26, 2023 12:15
@AbhiPrasad AbhiPrasad self-assigned this Sep 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees

@AbhiPrasad AbhiPrasad

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @iambriccardo