ref(metrics): Use usage metric in the billing consumer #57759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iker-barriocanal
approved these changes
Oct 9, 2023
jjbayer
approved these changes
Oct 9, 2023
| @@ -90,6 +90,7 @@ | |||
| "g:transactions/alert@none": PREFIX + 135, | |||
| "d:transactions/duration_light@millisecond": PREFIX + 136, | |||
| "c:transactions/usage@none": PREFIX + 137, | |||
| # Last possible index: 199 | |||
| #: See https://github.com/getsentry/relay/blob/4f3e224d5eeea8922fe42163552e8f20db674e86/relay-server/src/metrics_extraction/transactions.rs#L71 | ||
| TRANSACTION_METRICS_EXTRACTION_VERSION = 2 | ||
| #: See https://github.com/getsentry/relay/blob/6181c6e80b9485ed394c40bc860586ae934704e2/relay-dynamic-config/src/metrics.rs#L85 | ||
| TRANSACTION_METRICS_EXTRACTION_VERSION = 3 |
There was a problem hiding this comment.
It will take a while for all project configs to update to version 3, so we will be in a state where Relay still emits outcomes (for rate limits) based on the old metric, but sentry already emits accepted outcomes based on the new metric. Can't think of an argument right now why this should matter, but it feels inconsistent.
There was a problem hiding this comment.
That's acceptable behavior, since both numbers are equal in practice.
There was a problem hiding this comment.
Should we continue accepting transaction duration outcomes for some time after upgrading the version to 3?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #57666 and getsentry/relay#2571.
Uses the new usage metric in the billing consumer. This also updates the metric
extraction version to 3 so that the usage metric is used for rate limiting.