Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hybridcloud) Remove smtp command from devserver #58361

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

markstory
Copy link
Member

Instead of spending the time to upgrade this to work with multi-region sentry, it is less effort to not have it anymore. We don't run this command in any environment, and it is not part of any commonly used developer workflow.

Instead of spending the time to upgrade this to work with multi-region
sentry, it is less effort to not have it anymore. We don't run this
command in any environment, and it is not part of any commonly used
developer workflow.
@markstory markstory requested a review from a team October 18, 2023 18:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 18, 2023
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is it worth mentioning this in a changelog or something in case any self-hosted users happen to be using it for whatever reason?

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #58361 (8f6e684) into master (71314de) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #58361   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files        5144     5143    -1     
  Lines      223981   223930   -51     
  Branches    37714    37706    -8     
=======================================
- Hits       177132   177095   -37     
+ Misses      41173    41164    -9     
+ Partials     5676     5671    -5     

see 5 files with indirect coverage changes

markstory added a commit to getsentry/develop that referenced this pull request Oct 19, 2023
markstory added a commit to getsentry/develop that referenced this pull request Oct 19, 2023
@markstory markstory merged commit 3f87fe3 into master Oct 19, 2023
51 checks passed
@markstory markstory deleted the feat-remove-smtp branch October 19, 2023 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants