Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Add a metric to count spans #59722

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Nov 9, 2023

No description provided.

@phacops phacops requested a review from a team as a code owner November 9, 2023 17:05
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #59722 (e73f8f1) into master (c1930a7) will increase coverage by 0.00%.
Report is 16 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #59722   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files        5173     5173           
  Lines      226854   226862    +8     
  Branches    38149    38149           
=======================================
+ Hits       183218   183233   +15     
+ Misses      38081    38076    -5     
+ Partials     5555     5553    -2     
Files Coverage Δ
src/sentry/integrations/discord/client.py 100.00% <100.00%> (ø)
src/sentry/integrations/discord/commands.py 100.00% <100.00%> (ø)
src/sentry/integrations/discord/integration.py 100.00% <100.00%> (ø)
src/sentry/search/events/datasets/metrics.py 83.24% <ø> (ø)
src/sentry/search/events/datasets/metrics_layer.py 84.90% <ø> (ø)
src/sentry/sentry_metrics/indexer/strings.py 100.00% <ø> (ø)
static/app/components/forms/formPanel.tsx 100.00% <ø> (ø)
static/app/components/sidebar/index.tsx 91.66% <ø> (ø)

... and 9 files with indirect coverage changes

@phacops phacops merged commit 7ae6354 into master Nov 9, 2023
50 checks passed
@phacops phacops deleted the pierre/spans-add-a-metric-for-counting-spans branch November 9, 2023 21:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants